Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Getting started page from command palette #258

Merged
merged 24 commits into from
Mar 20, 2020

Conversation

xnkevinnguyen
Copy link
Contributor

@xnkevinnguyen xnkevinnguyen commented Mar 13, 2020

Description:

Open the getting started page and switch between devices. AB#34021
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xnkevinnguyen xnkevinnguyen changed the title WIP: Getting started page from command palette Getting started page from command palette Mar 13, 2020
Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The steps in the tutorial were super easy to follow! A bit more polish and I am confident that this will be a great place to start your computer science career :)

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests! LGTM.

@xnkevinnguyen xnkevinnguyen force-pushed the users/t-xunguy/getting-started branch from 4938445 to ac940ff Compare March 19, 2020 19:15
@xnkevinnguyen xnkevinnguyen merged commit 9a667a8 into dev Mar 20, 2020
@xnkevinnguyen xnkevinnguyen deleted the users/t-xunguy/getting-started branch March 20, 2020 00:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants