Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Removing preview mode #265

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Removing preview mode #265

merged 3 commits into from
Mar 19, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Mar 18, 2020

AB#34122

Description:

  • Removed preview mode setting, so microbit commands show up regardless
  • If anyone has a better idea to remove it so that it is easy to add once again (for clue), please let me know

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Are you sure you want to delete preview mode? If you add any new devices, I assume you would first offer them through the preview mode.
You would need to add everything back in that case, right?

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and good! 😎

@vandyliu
Copy link
Contributor Author

vandyliu commented Mar 18, 2020

LGTM.
Are you sure you want to delete preview mode? If you add any new devices, I assume you would first offer them through the preview mode.
You would need to add everything back in that case, right?

@nasadigital
Yeah, we would have to add everything back. I'm not sure what the best way to do this is. Maybe we can hold off on this until we decide on a release date for sure?

@nasadigital
Copy link

@nasadigital
Yeah, we would have to add everything back. I'm not sure what the best way to do this is. Maybe we can hold off on this until we decide on a release date for sure?

@vandyliu Up to you! Was just curious.

@vandyliu vandyliu merged commit 3810e54 into dev Mar 19, 2020
@vandyliu vandyliu deleted the users/t-vali/remove-preview-mode branch March 19, 2020 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants