Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

README change (more stuff for microbit) part 1 #270

Merged
merged 14 commits into from
Mar 23, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Mar 19, 2020

AB#34117

Description:

Type of change

Please delete options that are not relevant.

  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vandyliu vandyliu changed the title README change WIP README change Mar 19, 2020
@vandyliu vandyliu changed the title WIP README change README change Mar 19, 2020
@vandyliu vandyliu changed the title README change README change (more stuff for microbit) Mar 19, 2020
Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally both devices have fair treatment. Very well done!

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️ ⚡️

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs are so much clearer now :O

@vandyliu vandyliu requested a review from andreamah March 21, 2020 19:23
Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more comment!!!

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks for making that last fix 😎

@vandyliu vandyliu changed the title README change (more stuff for microbit) README change (more stuff for microbit) part 1 Mar 23, 2020
@vandyliu vandyliu merged commit 0607c1e into dev Mar 23, 2020
@vandyliu vandyliu deleted the users/t-vali/description-change branch March 23, 2020 00:59
@vandyliu vandyliu restored the users/t-vali/description-change branch March 23, 2020 00:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants