Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Changes to address Accessibility Insights #276

Merged
merged 11 commits into from
Mar 24, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Mar 23, 2020

AB#34189

Description:

  • Ran accessibility insights for Windows on the micro:bit webview and CPX webview and made adjustments according to the failed tests.
  • The failed tests that were:
    The Name must not include the same text as the LocalizedControlType
    The Name property must not include the element's control type
    They now pass with these new changes
  • Changed 'pin' type to 'button' because it is clickable

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vandyliu vandyliu changed the title (WIP) Changes to address Accessibility Insights Changes to address Accessibility Insights Mar 24, 2020
Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! LGTM 🥇

Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for making it even more accessible~~~

@vandyliu vandyliu merged commit 813b285 into dev Mar 24, 2020
@vandyliu vandyliu deleted the users/t-vali/accessibility-changes branch March 24, 2020 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants