Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Deploy to Clue and Deploy Command Pallete Refactoring #279

Merged
merged 7 commits into from
Mar 30, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Mar 26, 2020

Description:

Deploy to device command

  • Added deployment to Adafruit Clue and its corresponding telemetry
  • Because Clue and CPX are so similar, I refactored some things to reuse as much code as possible
  • Changed commands so that deploy to device is one command (and we don't have one for each device) then when the command is selected, the user can select which device they want.
  • Added TelemetryHandlerService to hold all functions that have to do with handling telemetry because there were just a bunch in extension.ts (it removes clutter)
  • Want opinions:
    @andreamah @xnkevinnguyen
    • Do you like this change? If so, I can update it for Open Simulator and New File.
    • Should we have the names of the devices more formal?
      • Eg. instead of CLUE, have it as Adafruit CLUE
      • Eg. instead of CPX, have it as Adafruit Circuit Playground Express or Circuit Playground Express
  • Will update README once Open Simulator and New File are updated (if they are updated).

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xnkevinnguyen
Copy link
Contributor

Regarding the commands, It's definitely a good improvement and will reduce the number of commands overall.

@xnkevinnguyen
Copy link
Contributor

Agreed with the formal name, Adafruit Clue, Adafruit Circuit Playground Express, BBC micro:bit

@andreamah
Copy link
Contributor

Sounds great! I agree with Kevin.

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@vandyliu vandyliu merged commit 9c9bc37 into dev Mar 30, 2020
@vandyliu vandyliu deleted the users/t-vali/clue-deploy branch March 30, 2020 18:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants