Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Template comments now include "To help you get started..." #296

Merged
merged 5 commits into from
Apr 6, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Apr 2, 2020

AB#34351

Description:

  • Added comment in every new file template:
    To get started, check out the "Device Simulator Express: Getting Started" command in the command pallete, which you can access with CMD + SHIFT + P For Mac and CTRL + SHIFT + P for Windows and Linux.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! Such a good idea 😮

Copy link
Contributor

@isadorasophia isadorasophia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 😁

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vandyliu vandyliu merged commit 03230d0 into dev Apr 6, 2020
@vandyliu vandyliu deleted the users/t-vali/getting-started-added-to-template branch April 6, 2020 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants