This repository was archived by the owner on Dec 23, 2021. It is now read-only.
Displayio Positioning Bug Fix #306
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issues:
group.x
orgroup.y
does not have an impact on the outputgroup.x
,group.y
,group.scale
when the group is active does not update the screenSolutions:
group.x
,group.y
, andgroup.scale
.adafruit_display_text
'sanchored_position
already updatesgroup.y
andgroup.x
, so we just needed to remove consideration for anchored_position and add reference togroup.y
andgroup.x
whenever we need to draw.Type of change
Please delete options that are not relevant.
Testing:
The example code here: https://github.com/adafruit/Adafruit_CircuitPython_CLUE/blob/master/examples/clue_spirit_level.py
(for the best result, use values between -10 and 10 for xy acceleration)
Also, the regular sensor code:
Checklist:
npm run format
and passes the checks innpm run check