Small Changes For Accessibility

[vandyliu]

Description:

• Added periods to end of sentences for descriptions that were missing them
• Added "title" to combo box because "name" wasn't giving it a name when Accessibility Insights tested it
• Changed "textbox" to "text" for call out because textbox has other properties that the callout does not have

Accessibility Insights Test:

Everything after Document (in red) is what we added to VS Code. Everything else is VS Code, which we cannot change.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A
• Test B

Checklist:

• My code follows the style guidelines of this project
• My code has been formatted with npm run format and passes the checks in npm run check
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[nasadigital]

LGTM.
Just curious, would it have been feasible to run accessibility insights as part of the CI pipeline?

[vandyliu]

LGTM.
Just curious, would it have been feasible to run accessibility insights as part of the CI pipeline?

I'm not 100% sure. When I do it, it's a Windows Application and I run it many times with the simulator in different states and then manually look through the UI Automation Tree. It would be cool to add though. We could definitely look into it.

[xnkevinnguyen]

Awesome! Glad our extension is accessible!!!