Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Max input length #312

Merged
merged 4 commits into from
Apr 9, 2020
Merged

Max input length #312

merged 4 commits into from
Apr 9, 2020

Conversation

xnkevinnguyen
Copy link
Contributor

Description:

The input will have max number of digit according to the length of the max value.

Previous behaviour: range 1-100, max length of input was hardcoded to 4
Current behaviour: range 1-100, max length of input is 3 because length of max is 100 ( 3 digits)

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@vandyliu vandyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice change :)

@xnkevinnguyen xnkevinnguyen merged commit 0de629c into dev Apr 9, 2020
@xnkevinnguyen xnkevinnguyen deleted the users/t-xunguy/dynamic-digit branch April 17, 2020 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants