Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Bug Fix for different values of Pressure on Python and React-side #322

Merged
merged 2 commits into from
Apr 13, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Apr 13, 2020

AB#34573

Description:

  • Sensor for pressure defaults to 1013
  • In the Python clue object, pressure defaults to 0, so this has been changed to match the sensor default

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!
I wonder if there was a reasonable solution to share the presets between the front end and back end.

@vandyliu
Copy link
Contributor Author

Nice catch!
I wonder if there was a reasonable solution to share the presets between the front end and back end.

Maybe store them all in a JSON document and load them from that or something to that degree?

@nasadigital
Copy link

Maybe store them all in a JSON document and load them from that or something to that degree?

Sounds like a good approach to me. Perhaps someone in the future will be able to work on that.

@vandyliu vandyliu merged commit 96aacb9 into dev Apr 13, 2020
@vandyliu vandyliu deleted the users/t-vali/pressure-python-wrong-value-bug branch April 13, 2020 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants