Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Getting Started Improvements #331

Merged
merged 9 commits into from
Apr 17, 2020
Merged

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Apr 15, 2020

AB#34549 AB#34555 AB#34552

Description:

  • Added debugger info on getting started
  • Added debugger to dropdown and added categories to dropdown
  • Removed bolding on h3 because there was too much boldness
  • Added keyboard shortcuts for device on getting started
  • Removed preview mode for CLUE getting started
  • NEED TO UPDATE PICTURE LINKS FOR DEBUGGER

Debug Page on Getting Started

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@andreamah
Copy link
Contributor

Can you increase the padding at the bottom of the page? It seems like it ends sorta abruptly:
image

Copy link
Contributor

@xnkevinnguyen xnkevinnguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge it once preview mode is removed :)

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Thanks for adding the padding 😎

@vandyliu vandyliu mentioned this pull request Apr 17, 2020
10 tasks
Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vandyliu vandyliu merged commit 3753cc1 into dev Apr 17, 2020
@vandyliu vandyliu deleted the users/t-vali/getting-started-improvements branch April 17, 2020 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants