Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Slideshow Backwards/Forwards Bug Fix #350

Merged
merged 4 commits into from
Apr 20, 2020
Merged

Conversation

andreamah
Copy link
Contributor

Description:

Addressing #348 .

When actively changing the playback direction of the clue slideshow, it previously did not correctly navigate back and forth. Made some fixes with the internal list so that it now can navigate correctly.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Testing:

Use the following:

from adafruit_clue import clue
from adafruit_slideshow import SlideShow, PlayBackDirection, PlayBackOrder

slideshow = SlideShow(clue.display,folder="pix",auto_advance=False)

while True:
    if clue.button_b:
        slideshow.direction = PlayBackDirection.FORWARD
        slideshow.advance()
    if clue.button_a:
        slideshow.direction = PlayBackDirection.BACKWARD
        slideshow.advance()

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@vandyliu vandyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great!

@andreamah andreamah merged commit f6d6122 into dev Apr 20, 2020
@andreamah andreamah deleted the users/t-anmah/slideshow-nav-bug branch April 20, 2020 23:48
andreamah added a commit that referenced this pull request Apr 21, 2020
* Add precision to input slider

* Fix inverse switch

* Refactor

* Switch default is false

* Modify precision value for cpx and clue

* Table of Contents for README (#349)

* Slideshow Backwards/Forwards Bug Fix (#350)

* slideshow nav fixed

* Fixed print() statements for CLUE display in debug mode (#351)

* fixed debug_user_code.py to capture print statements

* added starting and ending print statements

* new release note apr 21

* added a few fixes

Co-authored-by: Vandy Liu <[email protected]>
Co-authored-by: Andrea Mah <[email protected]>
Co-authored-by: andreamah <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants