Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Add filter for clue message #358

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Add filter for clue message #358

merged 2 commits into from
Apr 22, 2020

Conversation

xnkevinnguyen
Copy link
Contributor

@xnkevinnguyen xnkevinnguyen commented Apr 21, 2020

Description:

Previously we didn't filter the clue messages on the device. Clue messages will be sent regardless of the device so we need to filter it out.

Steps to reproduce:
1-Open micro:bit simulator
2-run micro:bit code on debug mode (any will do)

current: microbit simulator will crash
expected: microbit simulator will perform as regular simulator

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@vandyliu vandyliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome fix :D

Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works!

@xnkevinnguyen xnkevinnguyen merged commit 74491dd into dev Apr 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants