Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Green LED turns on when running code #58

Merged

Conversation

LukeSlev
Copy link
Member

@LukeSlev LukeSlev commented Jul 17, 2019

Description:

This PR makes it so that the green LED is only on when code is running and is not on errors. It also contains a variety of linting fixes

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing:

  • Green LED is on when code is running
  • Green LED is off when there are errors in the code or when you stop the simulator

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@LukeSlev LukeSlev changed the base branch from dev to users/t-luslev/add-play-webview July 18, 2019 00:29
@LukeSlev
Copy link
Member Author

Thanks @smmatte ! 🚀

Copy link
Contributor

@jonathanwangg jonathanwangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally and it works. Code improvements look great!

@LukeSlev LukeSlev merged commit 76bcaf5 into users/t-luslev/add-play-webview Jul 18, 2019
LukeSlev added a commit that referenced this pull request Jul 18, 2019
@LukeSlev LukeSlev deleted the users/t-luslev/fix-green-led branch August 7, 2019 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants