-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The user flow for getting to the tutorial feels very weird.
e.g.) There is no "OK" button to proceed to the external website on the first modal.
e.g.) From the first modal, even after clicking cancel, the second modal still pops up.
@jonathanwangg made some changes have another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice changes. Thanks for the update!
Co-Authored-By: Jonathan Wang <[email protected]>
Co-Authored-By: Jonathan Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question, beside that tested and works as expected 👍
src/constants.ts
Outdated
@@ -136,6 +139,8 @@ export namespace DialogResponses { | |||
export const DONT_SHOW: MessageItem = { | |||
title: localize("dialogResponses.dontShowAgain", "Don't Show Again") | |||
}; | |||
export const ACCEPT_PRIVACY: MessageItem = { title: localize("dialogResponses.acceptPrivacy", "Got it") }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the PR 63 (https://github.com/microsoft/vscode-python-embedded/pull/63/files) about filename checks, there is another "Got it option" constant that's being added. Do we want to keep them separate ?
Description:
This PR adds a privacy modal to external links in our app.
Type of change
Please delete options that are not relevant.
Limitations:
Due to limitations in the notification api, we can't put hyperlinks into the notifications so the user will have to copy and paste the privacy link themselves.
Testing:
Checklist: