Added notification when filename is wrong. #63

FMounz · 2019-07-19T00:51:55Z

Description:

This PR adds notification to the user when the file name being deployed or simulated is not main.py or code.py. We have that notification for the deployment, the simulation and the debugger.
A button is present on the simulator so it won't show another time during the session.
The deployment and debugging are cancelled in that case. The simulation will still happen.

Type of change

New feature (non-breaking change which adds functionality)

Limitations:

Please describe limitations of this PR

Testing:

Open a Python file which name is not code.py or main.py. An error message should appear when running the "deploy to device command", deployment should not happen.
Open a Python file which name is not code.py or main.py. An information message should appear when running the Pacifica debugger debugging continue. When clicking on the "Got it" or "Don't show again" button , the pop-up should close.
Open a Python file which name is not code.py or main.py. An information pop-up should appear when running the "run to device command". When clicking on the "Got it" or "Don't show again" button , the pop-up should close.
After clicking on "Don't show again" the message should not appear the next time.

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
Any dependent changes have been merged and published in downstream modules

locales/en/out/constants.i18n.json

src/constants.ts

Co-Authored-By: Jonathan Wang <[email protected]>

src/extension.ts

jonathanwangg

Please look at suggestions. For the behavior of the debugger for the simulator, we want it such that we can still run .py files, but notify the user that if they want to run the same file on the device, they should rename it to code.py or main.py.

FMounz · 2019-07-19T17:46:23Z

Please look at suggestions. For the behavior of the debugger for the simulator, we want it such that we can still run .py files, but notify the user that if they want to run the same file on the device, they should rename it to code.py or main.py.

Made some changes check them out.

locales/en/out/constants.i18n.json

src/constants.ts

jonathanwangg

Looks alright to me aside from the capitalization of "python".

LukeSlev

@FMounz Some needed changes! but other than that looks good

locales/en/out/constants.i18n.json

src/constants.ts

src/simulatorDebugConfigurationProvider.ts

Co-Authored-By: Luke Slevinsky <[email protected]>

…crosoft/vscode-python-embedded into users/t-chcido/filename-check

Co-Authored-By: Luke Slevinsky <[email protected]>

Christellah

Seems to work fine, just some suggestions/questions, specially reformatting would be nice :)

src/constants.ts

DIGarnier

Unsolicited advice 2: Electric boogaloo

DIGarnier · 2019-07-21T01:43:33Z

src/extension.ts

+          ...[
+            DialogResponses.DONT_SHOW,
+            DialogResponses.MESSAGE_UNDERSTOOD
+          ]


Is there a reason why you're wrapping those enum values in an array and spreading them right after?

I don't understand what you mean by spreading them right after?

If you put something in an array and then use the spread operator ... you're taking the elements out of the array as if they we're never in one to begin with!

look what happens here if you press play

I get you now after reading this .
Thanks for that very enlighting

src/simulatorDebugConfigurationProvider.ts

src/view/components/toolbar/TemperatureSensorBar.tsx

LukeSlev

LGTM, one comment

LukeSlev · 2019-07-21T08:35:16Z

src/simulatorDebugConfigurationProvider.ts

+        }else if(!validCodeFileName(currentFilePath) && shouldShowInvalidFileNamePopup){
+          vscode.window
+          .showInformationMessage(CONSTANTS.INFO.INVALID_FILE_NAME_DEBUG,
+          ...[


if we're removing the spread operator elsewhere might as well do it here too?

Christella Cidolit and others added 3 commits July 18, 2019 11:39

Adding notification for the file name deployed to device

80be2fe

added popup for simulator

a3654e0

changed the message

7ae7f2d

FMounz requested review from jonathanwangg, Christellah and LukeSlev July 19, 2019 00:51

FMounz requested review from abmahdy, adclements, markAtMicrosoft and smmatte as code owners July 19, 2019 00:51

jonathanwangg reviewed Jul 19, 2019

View reviewed changes

locales/en/out/constants.i18n.json Outdated Show resolved Hide resolved

jonathanwangg reviewed Jul 19, 2019

View reviewed changes

src/constants.ts Outdated Show resolved Hide resolved

jonathanwangg reviewed Jul 19, 2019

View reviewed changes

src/constants.ts Outdated Show resolved Hide resolved

FMounz and others added 3 commits July 19, 2019 09:47

Update locales/en/out/constants.i18n.json

0d98482

Co-Authored-By: Jonathan Wang <[email protected]>

changed constant

dfe1af6

removed link from outputchannel

e28ff19

jonathanwangg reviewed Jul 19, 2019

View reviewed changes

src/extension.ts Outdated Show resolved Hide resolved

jonathanwangg suggested changes Jul 19, 2019

View reviewed changes

Fatou Mounzeo added 3 commits July 19, 2019 10:34

changed error debug

8d6af89

changed condition

e6ff645

solved typo

43466dd

Fatou Mounzeo added 3 commits July 19, 2019 12:03

merge with dev

da221ab

changed code

47b49b4

removed white line

01c54f8

jonathanwangg reviewed Jul 19, 2019

View reviewed changes

locales/en/out/constants.i18n.json Outdated Show resolved Hide resolved

jonathanwangg reviewed Jul 19, 2019

View reviewed changes

src/constants.ts Outdated Show resolved Hide resolved

jonathanwangg approved these changes Jul 19, 2019

View reviewed changes

LukeSlev suggested changes Jul 19, 2019

View reviewed changes

Update locales/en/out/constants.i18n.json

0d53754

Co-Authored-By: Luke Slevinsky <[email protected]>

FMounz and others added 9 commits July 19, 2019 17:47

Update locales/en/out/constants.i18n.json

4dfea65

Co-Authored-By: Luke Slevinsky <[email protected]>

Update src/constants.ts

980cdb5

Co-Authored-By: Luke Slevinsky <[email protected]>

Update src/constants.ts

1026868

Co-Authored-By: Luke Slevinsky <[email protected]>

changes

515f840

Merge branch 'users/t-chcido/filename-check' of https://github.com/mi…

16cb522

…crosoft/vscode-python-embedded into users/t-chcido/filename-check

Update locales/en/out/constants.i18n.json

0201ce3

Co-Authored-By: Luke Slevinsky <[email protected]>

Update src/constants.ts

333a11a

Co-Authored-By: Luke Slevinsky <[email protected]>

added capital P to Python

8bada49

changed python to Python

1f2e781

Christellah suggested changes Jul 20, 2019

View reviewed changes

src/constants.ts Outdated Show resolved Hide resolved

src/constants.ts Outdated Show resolved Hide resolved

src/constants.ts Outdated Show resolved Hide resolved

Fatou Mounzeo added 3 commits July 19, 2019 23:16

changes

c8fcfa8

Merge branch 'dev' into users/t-chcido/filename-check

4bfe5a0

used prettier

ae33c00

Christellah approved these changes Jul 20, 2019

View reviewed changes

DIGarnier reviewed Jul 21, 2019

View reviewed changes

removed useless characters

f8903ca

DIGarnier reviewed Jul 21, 2019

View reviewed changes

src/view/components/toolbar/TemperatureSensorBar.tsx Outdated Show resolved Hide resolved

removed spreding operator

8c1a558

LukeSlev approved these changes Jul 21, 2019

View reviewed changes

Fatou Mounzeo added 3 commits July 21, 2019 12:42

Merge branch 'dev' into users/t-chcido/filename-check

4df6598

merged with dev

34d2207

deleted unused file

1c9380c

FMounz merged commit 81b57ee into dev Jul 22, 2019

Christellah deleted the users/t-chcido/filename-check branch August 7, 2019 18:21

Added notification when filename is wrong. #63

Added notification when filename is wrong. #63

Uh oh!

Conversation

FMounz commented Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Type of change

Limitations:

Testing:

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonathanwangg left a comment

Choose a reason for hiding this comment

Uh oh!

FMounz commented Jul 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jonathanwangg left a comment

Choose a reason for hiding this comment

Uh oh!

LukeSlev left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Christellah left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DIGarnier left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DIGarnier Jul 21, 2019

Choose a reason for hiding this comment

Uh oh!

FMounz Jul 21, 2019

Choose a reason for hiding this comment

Uh oh!

FMounz Jul 21, 2019

Choose a reason for hiding this comment

Uh oh!

DIGarnier Jul 21, 2019

Choose a reason for hiding this comment

Uh oh!

FMounz Jul 21, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LukeSlev left a comment

Choose a reason for hiding this comment

Uh oh!

LukeSlev Jul 21, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

FMounz commented Jul 19, 2019 •

edited

Loading

FMounz commented Jul 19, 2019 •

edited

Loading

DIGarnier left a comment •

edited

Loading