Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Adding a scrollbar to contain the sensor #69

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Conversation

FMounz
Copy link
Contributor

@FMounz FMounz commented Jul 29, 2019

Description:

This PR adds a scrollbar that will contain the sensors controller to be added.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

There are not enough controller to see the impact of this scrollbar so the box has been given a small size to ensure it works

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • You see the scrollbar
  • The temperature sensor still works as expected

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Member

@LukeSlev LukeSlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but probably change the max height @FMounz

Copy link
Contributor

@Christellah Christellah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with the comment made by @LukeSlev the scrollbox is too tiny.
Beside that I tried duplicating the Temperature Sensor and the scrolling seems to work fine 👍

@FMounz FMounz merged commit 806ab9f into dev Jul 29, 2019
@FMounz FMounz deleted the users/t-famoun/scrollbar branch August 10, 2019 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants