Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Remove unneeded lines of code #74

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Conversation

LukeSlev
Copy link
Member

Description:

This PR removes some unneeded code. Found this while reviewing another PR.

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Testing:

  • make sure button clicks still work

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@jonathanwangg jonathanwangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

Copy link
Contributor

@Christellah Christellah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested & seems to work 🤖

@LukeSlev LukeSlev merged commit 383e897 into dev Jul 30, 2019
@LukeSlev LukeSlev deleted the users/t-luslev/remove-unneeded-state branch August 7, 2019 23:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants