Skip to content
This repository was archived by the owner on Dec 23, 2021. It is now read-only.

Adding the toolbar with the icons #84

Merged
merged 101 commits into from
Aug 1, 2019
Merged

Adding the toolbar with the icons #84

merged 101 commits into from
Aug 1, 2019

Conversation

FMounz
Copy link
Contributor

@FMounz FMounz commented Jul 31, 2019

Description:

This Pull request adds to the WebView a toolbar that contains multiple icons (see design)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Limitations:

This PR is exclusively about UI change no test are available.

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Check that the toolbar conforms to the design provided.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@@ -49,6 +49,8 @@ const DEFAULT_CPX_STATE: ICpxState = {
switch: false
};

const SIMULATOR_BUTTO_WIDTH = 60;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo with BUTTO

@FMounz FMounz merged commit a2c7c0f into dev Aug 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants