-
Notifications
You must be signed in to change notification settings - Fork 50
Adding capacitive touch support to the simulator #94
Conversation
Stopping the simulator does not remove the "touches". Should it? I feel like that may be a good idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FMounz Some comments. Also you should sync with @MichelleYAOOO because I think we want the capacitive touch to work like the buttons in terms of clicking them. people can use the keyboard if they want to press more than one at the same time. Also, there are some premade css classes that you could use in that file like https://github.com/microsoft/vscode-python-embedded/blob/users/t-famoun/capacitive_touch/src/view/components/cpx/Cpx_svg_style.tsx#L257
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also the capacitive touch pins don't work like buttons do (border stroke width gets bigger and its an orange color).They probably should
The color on the button is attenuated by the gray border, it is not lighter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@FMounz Sorry one last thing can you please add python tests
Description:
This PR adds the capacitive touch to the supported sensors. To simulate the touch of one of the pin click on it once. and it change its state to touch , click on it once more and it is untouched. numeric pad (key 1 to 7) can be used also to simulate the touch.The value of those pin can be retrieved by the user with cpx.touch_A
Type of change
Please delete options that are not relevant.
Limitations:
Please describe limitations of this PR
Testing:
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
-[]Add to code.py an example code that use cpx.touch_A. The Simulator should be updated accordingly. Example:
Checklist: