(Black) Formatter & Pytest fail with .env in Python

[sleighsoft]

Environment data

VSCode: Most recent non-insider version.
Python: 3.7
Black: Most recent.

Expected behaviour

Black is registered as a formatter.
Code is formatted.

Actual behaviour

Nothing happens.

Steps to reproduce:

Working:

1. Register black as the formatter of choice.
2. Create a directory with the following structure:

root
- project
  - file_to_be_formatted.py

3. Add some code into file_to_be_formatted.py that has formatting issues.
4. Run black with alt + shift + f. It formats the code!

Failing:

1. Register black as the formatter of choice.
2. Create a directory with the following structure:

root
- .env (This contains "PYTHONPATH=./project" to make properly configure package detection, etc.)
- project
  - file_to_be_formatted.py

3. Add some code into file_to_be_formatted.py that has formatting issues.
4. Run black with alt + shift + f. It does not format the code

So having a .env file will silently make black fail. Running black from the command line on file_to_be_formatted.py does still work

I follow this: https://github.com/microsoft/python-language-server/blob/master/TROUBLESHOOTING.md#unresolved-import-warnings

[kimadeline]

Hi @sleighsoft , thank you for reaching out!

Can you please share the following so that I can try to reproduce your issue:

• The content of the Python output panel (View→Output, change the drop-down the upper-right of the Output panel to Python) when formatting works and fails;
• The content of your .vscode/settings.json file;
• The content of your .env file.

Also, does formatting work if you use a different formatter, or if you use jedi instead of the MPLS?

Thanks!

[sleighsoft]

workspace structure

project
- project
   - file_to_be_formatted.py
- .vscode
- .env
- project.code-workspace

.env

PYTHONPATH=./project

Output of pressing shift + alt + f once

> C:\Progams\Miniconda\envs\project\python.exe -m black --diff --quiet c:\Development\github\project\project\test_decorator.py
cwd: c:\Development\github\project
> C:\Progams\Miniconda\envs\project\python.exe -m black --diff --quiet c:\Development\github\project\project\test_decorator.py
cwd: c:\Development\github\project

.vscode/settings.json

{
    "python.pythonPath": "C:\\Progams\\Miniconda\\envs\\project\\python.exe",
    "python.formatting.provider": "black"
}

autopep8 also fails

output

> C:\Progams\Miniconda\envs\project\python.exe -m autopep8 --diff c:\Development\github\project\project\test_decorator.py
cwd: c:\Development\github\project
> C:\Progams\Miniconda\envs\project\python.exe -m autopep8 --diff c:\Development\github\project\project\test_decorator.py
cwd: c:\Development\github\project

jedi also fails

[kimadeline]

Does formatting work if you run C:\Progams\Miniconda\envs\project\python.exe -m black --diff --quiet c:\Development\github\project\project\test_decorator.py from the c:\Development\github\project directory?

[sleighsoft]

It does work. It outputs a diff with the proper formatting.

[sleighsoft]

Pytest also fails.

I just tried out builtin pytest. It also fails to discover tests when the .env file is set.

It works when removing the .env file.

Output

> C:\Progams\Miniconda\envs\project\python.exe c:\Users\Me\.vscode\extensions\ms-python.python-2020.2.64397\pythonFiles\testing_tools\run_adapter.py discover pytest -- --rootdir c:\Development\github\project -s --cache-clear
cwd: c:\Development\github\project

[kimadeline]

Can you try removing PYTHONPATH from the .env file?

[sleighsoft]

Removing PYTHONPATH and reloading VSCode enables black/pytest again.

Setting PYTHONPATH within .env breaks the tooling.

[kimadeline]

I couldn't reproduce your issue with the following structure:

root/
   .venv/ (virtual environment folder)
   .vscode/
   project/
      file_to_format.py
   .env

and the content of the .env file being

PYTHONPATH=./project

Black formats file_to_format.py correctly. Do you have a sample repo I could use to try and replicate your issue?

Also, does the tooling (black and pytest) work correctly if you use the other options for passing the extra roots to the language server, either by specify PYTHONPATH in your env variables directly or using the "python.autoComplete.extraPaths" setting?