Slashes not escaped in paths when activating conda environments in Git Bash on Windows

[keithyipkw]

Upon opening a new Bash,

$ C:\ProgramData\Anaconda3\Scripts\activate mkl
bash: C:ProgramDataAnaconda3Scriptsactivate: command not found

The correct command should be using escaped backslashes or forward slashes

$ C:\\ProgramData\\Anaconda3\\Scripts\\activate mkl
$ C:/ProgramData/Anaconda3/Scripts/activate mkl

Interestingly, the command for activating the base environment is

$ C:/ProgramData/Anaconda3/Scripts/activate

Environment data

• VS Code version: 1.44.2
• Extension version (available under the Extensions sidebar): 2020.4.74986
• OS and version: Windows_NT x64 10.0.18362
• Python version (& distribution if applicable, e.g. Anaconda): Anaconda 4.8.2
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
• Relevant/affected Python packages and their versions: all
• Relevant/affected Python-related VS Code extensions and their versions: N/A
• Jedi or Language Server? (i.e. what is "python.jediEnabled" set to; more info How to update the language server to the latest stable version #3977): true
• Value of the python.languageServer setting: Microsoft

Expected behaviour

The environment is activated.

Actual behaviour

"command not found" is displayed.

Steps to reproduce:

1. Ensure python.terminal.activateEnvironment to be true
2. Select an Anaconda environment other than the base
3. Open a new terminal

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)

Activating environments other than the base

workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:04:14: getActivatedEnvironmentVariables, Class name = _, completed in 381ms, has a truthy return value, Arg 1: undefined
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:04:18: Shell path 'bash'
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:04:18: Shell path identified as shell 'bash'
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:04:18: Terminal name 'bash' identified as shell 'bash'
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:04:18: [object Object]. Shell identified as bash (Terminal name is bash)
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:04:18: Shell identified as 'bash'
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:04:18: Get Conda environments, Class name = b, completed in 0ms, has a truthy return value, Arg 1: false, Return Value: [{"name":"base","path":"C:\\ProgramData\\Anaconda3"},{"name":"mkl","path":"C:\\Users\\user\\.conda\\envs\\mkl"},{"name":"py2","path":"C:\\Users\\user\\.conda\\envs\\py2"},{"name":"py27_32","path":"C:\\Users\\user\\.conda\\envs\\py27_32"}]
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:04:18: Cached data exists KeyPrefix=Cache_Method_Output_b.getCondaVersion-Args=
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:04:18: Cached data exists KeyPrefix=Cache_Method_Output_b.getCondaFileFromInterpreter-Args="C:\\Users\\user\\.conda\\envs\\mkl\\python.exe"-Arg-Separator-"mkl"
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:04:18: Get Conda File from interpreter, Class name = b, completed in 0ms, has a falsy return value, Arg 1: "C:\\Users\\user\\.conda\\envs\\mkl\\python.exe", Arg 2: "mkl", Return Value: undefined

Activiting the base

workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:07:35: Shell path 'bash'
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:07:35: Shell path identified as shell 'bash'
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:07:35: Terminal name 'bash' identified as shell 'bash'
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:07:35: [object Object]. Shell identified as bash (Terminal name is bash)
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:07:35: Shell identified as 'bash'
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:07:35: Get Conda environments, Class name = b, completed in 0ms, has a truthy return value, Arg 1: false, Return Value: [{"name":"base","path":"C:\\ProgramData\\Anaconda3"},{"name":"mkl","path":"C:\\Users\\user\\.conda\\envs\\mkl"},{"name":"py2","path":"C:\\Users\\user\\.conda\\envs\\py2"},{"name":"py27_32","path":"C:\\Users\\user\\.conda\\envs\\py27_32"}]
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:07:35: Cached data exists KeyPrefix=Cache_Method_Output_b.getCondaVersion-Args=
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:07:35: Cached data exists KeyPrefix=Cache_Method_Output_b.getCondaFileFromInterpreter-Args="C:\\ProgramData\\Anaconda3\\python.exe"-Arg-Separator-"base"
workbench.desktop.main.js:sourcemap:262 [Extension Host] Info Python Extension: 2020-04-26 15:07:35: Get Conda File from interpreter, Class name = b, completed in 0ms, has a truthy return value, Arg 1: "C:\\ProgramData\\Anaconda3\\python.exe", Arg 2: "base", Return Value: "C:\\ProgramData\\Anaconda3\\Scripts\\conda.exe"

[kimadeline]

Hello @keithyipkw, thank you for reaching out.

What is the value for terminal.integrated.shell.windows in your user settings and in your workspace settings? When you say bash, do you mean the WSL shell? Does this issue only happen with this shell, or with Powershell and the command prompt as well?

Thanks!

[keithyipkw]

Hello @keithyipkw, thank you for reaching out.

What is the value for terminal.integrated.shell.windows in your user settings and in your workspace settings? When you say bash, do you mean the WSL shell? Does this issue only happen with this shell, or with Powershell and the command prompt as well?

Thanks!

"terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe",

[kimadeline]

Is this from your user settings, or your workspace settings (the .vscode/settings.json file in your folder)?

[keithyipkw]

Is this from your user settings, or your workspace settings (the .vscode/settings.json file in your folder)?

It is from my user settings.

[kimadeline]

Sorry for the late reply @keithyipkw (was working on issues related to Windows Store installations of Python, so I had to scrub out and then setup conda again) but I couldn't reproduce your issue:

What's the content of your .vscode/settings.json file? And what is the path being displayed when you select your interpreter:

Thank you!

[keithyipkw]

What's the content of your .vscode/settings.json file? And what is the path being displayed when you select your interpreter:

The activation command is correct if I select "base". It is wrong only if I select any other environments.

.vscode/settings.json

{
    "python.pythonPath": "C:\\Users\\user\\.conda\\envs\\mkl\\python.exe"
}

The path for the interpreter is

~\.conda\envs\mkl\python.exe

For comparison, they are the following for "base"

{
    "python.pythonPath": "C:\\ProgramData\\Anaconda3\\python.exe"
}

C:\ProgramData\Anaconda3\python.exe

[kimadeline]

When you write .conda in your settings and interpreter path, is this a shorthand for anaconda/miniconda, or is your environment folder actually named .conda?

It's also pretty strange that you get a full length activation command (C:\ProgramData\Anaconda3\Scripts\activate mkl) when it should be a 2-step process (C:\\ProgramData\\Anaconda3\\Scripts\\activate followed by conda activate mkl).

How did you create the mkl environment?

[keithyipkw]

When you write .conda in your settings and interpreter path, is this a shorthand for anaconda/miniconda, or is your environment folder actually named .conda?

It's also pretty strange that you get a full length activation command (C:\ProgramData\Anaconda3\Scripts\activate mkl) when it should be a 2-step process (C:\\ProgramData\\Anaconda3\\Scripts\\activate followed by conda activate mkl).

How did you create the mkl environment?

Which properties in which VS settings did you mean?

settings.json in AppData

{
    "workbench.colorTheme": "Visual Studio Light",
    "editor.fontFamily": "'Source Code Pro', 'Courier New', monospace",
    "editor.fontSize": 15,
    "editor.autoSurround": "never",
    "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe",
    "workbench.startupEditor": "none",
    "editor.smoothScrolling": true,
    "editor.mouseWheelScrollSensitivity": 0.75,
    "editor.wordWrap": "on",
    "editor.find.seedSearchStringFromSelection": false,
    "latex-workshop.view.pdf.viewer": "tab",
    "window.zoomLevel": 0,
    "python.condaPath": "C:\\ProgramData\\Anaconda3\\Scripts\\conda.exe",
    "python.terminal.activateEnvInCurrentTerminal": true,
    "terminal.integrated.shellArgs.windows": ["-l"],
}

.vs/settings.json

{
    "python.pythonPath": "C:\\Users\\user\\.conda\\envs\\mkl\\python.exe"
}

It is a 2-step process for activating my base

$ C:/ProgramData/Anaconda3/Scripts/activate

$ conda activate base

Comparing to selecting a non-base env

$ C:\ProgramData\Anaconda3\Scripts\activate mkl
bash: C:ProgramDataAnaconda3Scriptsactivate: command not found

I created my envs in Anaconda Prompt following this doc https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-environments.html
They were something like this

conda create -n myenv python=3.6

[kimadeline]

Good news: I think we're getting closer to figuring out why you are getting 2 different activation commands 🔎

In condaActivationProvider.ts we have some code that activates environments differently depending on your version of conda:

• if conda is > 4.6 and we're not using powershell then we send 2 activation commands (what you see with base);
• otherwise we send one activation command (what is happening with mkl).

Now, I know you mentioned in your original command that you use Anaconda 4.8.2, can you run the following commands outside of VS Code, and copy their output here, so we can try and narrow down where the extension trips up:

• conda --version when you have the base environment activated
• conda --version when you have the mkl environment activated
• conda info --json when you have the base environment activated
• conda info --json when you have the mkl environment activated

Thank you for your help!