Skip to content

Respect the "files.exclude" setting when using rope to refactor. #12287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
p-se opened this issue Jun 11, 2020 · 6 comments
Closed

Respect the "files.exclude" setting when using rope to refactor. #12287

p-se opened this issue Jun 11, 2020 · 6 comments
Assignees
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality

Comments

@p-se
Copy link

p-se commented Jun 11, 2020

Basically just the same issue as #9770. I would have added this information there, but unfortunately, this is not possible, as the issue has been locked.

I'm having the same issue and would have expected to be able to resolve the issue by configuring vscode properly.

I provide additional and requested information on how this behavior can be reproduced.

rope-refactor-bug

@p-se p-se added data science bug Issue identified by VS Code Team member as probable bug labels Jun 11, 2020
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Jun 15, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jun 16, 2020
@ericsnowcurrently
Copy link

@p-se, thanks for letting us know about this. What happens when you use the language server? Make sure the following is in your settings.json:

{
    "python.jediEnabled": false,
    "python.languageServer": "Microsoft"
}

@ericsnowcurrently ericsnowcurrently added the info-needed Issue requires more information from poster label Jun 16, 2020
@p-se
Copy link
Author

p-se commented Jun 16, 2020

@ericsnowcurrently, thanks for the response! Enabling the language server works in the provided workspace. The issue is not present there.

However, when I enable the language server, I have issue with very basic features in bigger and somewhat chaotic projects (at least from a Python point of view). I've not yet created an issue for that, but part of the problem is also that the memory is being eaten up as well as completion is not working and even basic information is not displayed, for instance when hovering over variables, does not work. This makes it unfortunately unusable for me. That's why I use jedi. I'll create an issue for that soon, too.

I assume the other issue is probably harder to resolve. It has been a companion for quite a while. I silently hoped it would be resolved without my intervention. I should have taken the time to report it earlier, but I'll catch up on that now.

@ericsnowcurrently
Copy link

Certainly we'd rather get the language server to work for your needs. If that isn't an option then this is more of an enhancement than a bug. We don't send VS Code's "files.exclude" list to rope. We could look into doing so, but it isn't even clear if rope supports that. Regardless, I'll go ahead and mark this as an enhancement request.

FWIW, if you haven't already, it would be very helpful to have a separate bug report from you on the problems you have had with the language server.

@jakebailey

@ericsnowcurrently ericsnowcurrently added area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. needs decision feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster triage bug Issue identified by VS Code Team member as probable bug labels Jun 22, 2020
@p-se
Copy link
Author

p-se commented Jun 23, 2020

Thanks for the info. I created the issue microsoft/python-language-server#2079 in the meantime and received help on it. It is about multiple symlinks the language server can't handle correctly. It is a duplicate of microsoft/python-language-server#2006.

My current workaround is to remove the symlinks and mark them as unchanged in git, which is not really clean, but it works for now. Since I got the chance to work with the language server, I would prefer to have the language server fixed, too.

Thanks for your help, it is much appreciated.

@ericsnowcurrently ericsnowcurrently changed the title Refactor with rope does not adhere to files.exclude #9770 Respect the "files.exclude" setting when using rope to refactor. Jun 23, 2020
@luabud
Copy link
Member

luabud commented Jul 22, 2020

However, when I enable the language server, I have issue with very basic features in bigger and somewhat chaotic projects (at least from a Python point of view). I've not yet created an issue for that, but part of the problem is also that the memory is being eaten up as well as completion is not working and even basic information is not displayed, for instance when hovering over variables, does not work. This makes it unfortunately unusable for me. That's why I use jedi. I'll create an issue for that soon, too.

We have recently released a new and more performant language server called Pylance which likely solves these issues you are reporting. You can download Pylance from the marketplace and install it alongside the core Python extension. Because our team's development efforts have shifted to support the new language server, we'd encourage you to try it out.

@luabud
Copy link
Member

luabud commented Jul 22, 2020

We talked about this issue with the team and we have unfortunately decided we will not be moving forward with this idea as we plan to remove support for rope (#10440).

@luabud luabud closed this as completed Jul 22, 2020
@ghost ghost removed the needs decision label Jul 22, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-intellisense LSP-related functionality: auto-complete, docstrings, navigation, refactoring, etc. feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

5 participants