Space in extension path: Linter functional tests failing

[rchiodo]

1. Linting Functional Tests
   Flake8:

   AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - flake8##########

   • expected - actual

   at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
   at Context. (out/test/linters/lint.functional.test.js:702:13)

2. Linting Functional Tests
   Pylint:

   AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pylint##########

   • expected - actual

   at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
   at processTicksAndRejections (internal/process/task_queues.js:94:5)
   at Context. (out/test/linters/lint.functional.test.js:702:13)

3. Linting Functional Tests
   Pycodestyle:

   AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pycodestyle##########

   • expected - actual

   at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
   at processTicksAndRejections (internal/process/task_queues.js:94:5)
   at Context. (out/test/linters/lint.functional.test.js:702:13)

4. Linting Functional Tests
   Pydocstyle:

   AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pydocstyle##########

   • expected - actual

   at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
   at Context. (out/test/linters/lint.functional.test.js:702:13)

5. Linting Functional Tests
   Flake8 with config in root:

   AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - flake8##########

   • expected - actual

   at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
   at processTicksAndRejections (internal/process/task_queues.js:94:5)
   at Context. (out/test/linters/lint.functional.test.js:726:17)

6. Linting Functional Tests
   Pycodestyle with config in root:

   AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pycodestyle##########

   • expected - actual

   at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
   at processTicksAndRejections (internal/process/task_queues.js:94:5)
   at Context. (out/test/linters/lint.functional.test.js:726:17)

7. Linting Functional Tests
   Three line output counted as one message:

   AssertionError [ERR_ASSERTION]: Expected number of lint errors does not match lint error count

   • expected - actual

   -0
   +5

   at testLinterMessageCount (out/test/linters/lint.functional.test.js:738:16)
   at processTicksAndRejections (internal/process/task_queues.js:94:5)
   at Context. (out/test/linters/lint.functional.test.js:744:9)

Steps to repro

1. Clone into extension path with a space
2. Run linter functional tests

Or if that doesn't work, run a github action as done in this PR
#14113

[kimadeline]

Could not repro with main 43a8716:

[rchiodo]

The 'spaces with path' is not in main unless you already pushed it? Meaning the tests are not running with a space in the path.

[karthiknadig]

We are not able to repro some of these when running with main. So, we should probably rebase the "space with path" PR and see if that gives the same errors again.

[kimadeline]

@rchiodo Sorry I didn't write it down correctly: I pulled main and ran a workflow that used a path with spaces, but without making changes to the code:

• workflow run: https://github.com/kimadeline/vscode-python/actions/runs/290195263
• workflow file: https://github.com/kimadeline/vscode-python/blob/713e706dadba1ec761693a1b7040952abc726895/.github/workflows/spaces.yml
• repo under a path with spaces:
  

And all tests passed without any changes other than that extra worfklow.