Skip to content

Space in extension path: Linter functional tests failing #14167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rchiodo opened this issue Sep 29, 2020 · 4 comments
Closed

Space in extension path: Linter functional tests failing #14167

rchiodo opened this issue Sep 29, 2020 · 4 comments
Labels
area-internal Label for non-user facing issues bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority

Comments

@rchiodo
Copy link

rchiodo commented Sep 29, 2020

  1. Linting Functional Tests
    Flake8:

    AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - flake8##########

    • expected - actual

    at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
    at Context. (out/test/linters/lint.functional.test.js:702:13)

  2. Linting Functional Tests
    Pylint:

    AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pylint##########

    • expected - actual

    at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at Context. (out/test/linters/lint.functional.test.js:702:13)

  3. Linting Functional Tests
    Pycodestyle:

    AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pycodestyle##########

    • expected - actual

    at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at Context. (out/test/linters/lint.functional.test.js:702:13)

  4. Linting Functional Tests
    Pydocstyle:

    AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pydocstyle##########

    • expected - actual

    at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
    at Context. (out/test/linters/lint.functional.test.js:702:13)

  5. Linting Functional Tests
    Flake8 with config in root:

    AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - flake8##########

    • expected - actual

    at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at Context. (out/test/linters/lint.functional.test.js:726:17)

  6. Linting Functional Tests
    Pycodestyle with config in root:

    AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pycodestyle##########

    • expected - actual

    at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at Context. (out/test/linters/lint.functional.test.js:726:17)

  7. Linting Functional Tests
    Three line output counted as one message:

    AssertionError [ERR_ASSERTION]: Expected number of lint errors does not match lint error count

    • expected - actual

    -0
    +5

    at testLinterMessageCount (out/test/linters/lint.functional.test.js:738:16)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at Context. (out/test/linters/lint.functional.test.js:744:9)

Steps to repro

  1. Clone into extension path with a space
  2. Run linter functional tests

Or if that doesn't work, run a github action as done in this PR
#14113

@rchiodo rchiodo added bug Issue identified by VS Code Team member as probable bug triage-needed Needs assignment to the proper sub-team important Issue identified as high-priority labels Sep 29, 2020
@karthiknadig karthiknadig added needs PR area-internal Label for non-user facing issues labels Sep 30, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Sep 30, 2020
@kimadeline
Copy link

Could not repro with main 43a8716:

image

@ghost ghost removed the needs PR label Oct 5, 2020
@rchiodo
Copy link
Author

rchiodo commented Oct 5, 2020

The 'spaces with path' is not in main unless you already pushed it? Meaning the tests are not running with a space in the path.

@rchiodo rchiodo reopened this Oct 5, 2020
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Oct 5, 2020
@karthiknadig
Copy link
Member

We are not able to repro some of these when running with main. So, we should probably rebase the "space with path" PR and see if that gives the same errors again.

@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Oct 6, 2020
@kimadeline
Copy link

kimadeline commented Oct 6, 2020

@rchiodo Sorry I didn't write it down correctly: I pulled main and ran a workflow that used a path with spaces, but without making changes to the code:

And all tests passed without any changes other than that extra worfklow.

@rchiodo rchiodo closed this as completed Oct 6, 2020
@ghost ghost removed the needs PR label Oct 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-internal Label for non-user facing issues bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority
Projects
None yet
Development

No branches or pull requests

3 participants