-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Space in extension path: Linter functional tests failing #14167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Could not repro with |
The 'spaces with path' is not in main unless you already pushed it? Meaning the tests are not running with a space in the path. |
We are not able to repro some of these when running with main. So, we should probably rebase the "space with path" PR and see if that gives the same errors again. |
@rchiodo Sorry I didn't write it down correctly: I pulled main and ran a workflow that used a path with spaces, but without making changes to the code:
And all tests passed without any changes other than that extra worfklow. |
Linting Functional Tests
Flake8:
AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - flake8##########
at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
at Context. (out/test/linters/lint.functional.test.js:702:13)
Linting Functional Tests
Pylint:
AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pylint##########
at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
at processTicksAndRejections (internal/process/task_queues.js:94:5)
at Context. (out/test/linters/lint.functional.test.js:702:13)
Linting Functional Tests
Pycodestyle:
AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pycodestyle##########
at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
at processTicksAndRejections (internal/process/task_queues.js:94:5)
at Context. (out/test/linters/lint.functional.test.js:702:13)
Linting Functional Tests
Pydocstyle:
AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pydocstyle##########
at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
at Context. (out/test/linters/lint.functional.test.js:702:13)
Linting Functional Tests
Flake8 with config in root:
AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - flake8##########
at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
at processTicksAndRejections (internal/process/task_queues.js:94:5)
at Context. (out/test/linters/lint.functional.test.js:726:17)
Linting Functional Tests
Pycodestyle with config in root:
AssertionError [ERR_ASSERTION]: No errors in linter, Output - ##########Linting Output - pycodestyle##########
at testLinterMessages (out/test/linters/lint.functional.test.js:691:24)
at processTicksAndRejections (internal/process/task_queues.js:94:5)
at Context. (out/test/linters/lint.functional.test.js:726:17)
Linting Functional Tests
Three line output counted as one message:
AssertionError [ERR_ASSERTION]: Expected number of lint errors does not match lint error count
-0
+5
at testLinterMessageCount (out/test/linters/lint.functional.test.js:738:16)
at processTicksAndRejections (internal/process/task_queues.js:94:5)
at Context. (out/test/linters/lint.functional.test.js:744:9)
Steps to repro
Or if that doesn't work, run a github action as done in this PR
#14113
The text was updated successfully, but these errors were encountered: