Skip to content

Remove start page code #16453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kimadeline opened this issue Jun 8, 2021 · 2 comments · Fixed by #16834
Closed

Remove start page code #16453

kimadeline opened this issue Jun 8, 2021 · 2 comments · Fixed by #16834
Assignees
@kimadeline
Labels
area-editor-* User-facing catch-all debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Milestone
August 2021

Comments

@kimadeline
Copy link

kimadeline commented Jun 8, 2021 •
edited
Loading

In #16417 we made a small change to the start page code (see this comment thread), but a general review of startPage.ts and startPage.tsx might be needed.

A couple of things I noticed here and there, but by no means an exhaustive list:

Do this work as part of #16678
@IanMatthewHuff IanMatthewHuff removed their assignment Jun 9, 2021
@DonJayamanne
Copy link

Moving back to Python repo, as this start page applies to Python all up, not just DS.

@DonJayamanne DonJayamanne transferred this issue from microsoft/vscode-jupyter Jun 10, 2021
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jun 10, 2021
@kimadeline kimadeline mentioned this issue Jun 12, 2021
Merged
@karthiknadig karthiknadig added area-editor-* User-facing catch-all needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority and removed triage-needed Needs assignment to the proper sub-team labels Jun 14, 2021
@karthiknadig karthiknadig changed the title Revisit start page code Remove start page code Jun 14, 2021
@karthiknadig
Copy link
Member

Since we are moving to VS Code start pages, we will be removing this.

@luabud luabud removed the important Issue identified as high-priority label Jun 23, 2021
This was referenced Jul 26, 2021
Merged
Merged
@kimadeline kimadeline self-assigned this Jul 30, 2021
@kimadeline kimadeline mentioned this issue Jul 30, 2021
Closed
@kimadeline kimadeline added this to the August 2021 milestone Aug 17, 2021
@kimadeline kimadeline added the verified Verification succeeded label Aug 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kimadeline kimadeline

Labels
area-editor-* User-facing catch-all debt Covers everything internal: CI, testing, refactoring of the codebase, etc. verified Verification succeeded
Projects
None yet
Milestone
August 2021
Development

Successfully merging a pull request may close this issue.

Remove start page and its build dependencies kimadeline/vscode-python
5 participants
@IanMatthewHuff @DonJayamanne @karthiknadig @luabud @kimadeline