Skip to content

Remove start page-related commands and display logic #16791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kimadeline
Copy link

@kimadeline kimadeline commented Jul 26, 2021

For #16453

This makes the existing start page inaccessible to prepare for #16709. The juicy code removal (+ news file) will be done in a separate PR 🧃

@kimadeline kimadeline added no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating labels Jul 26, 2021
@kimadeline kimadeline self-assigned this Jul 26, 2021
@kimadeline kimadeline marked this pull request as ready for review July 26, 2021 16:18
@kimadeline kimadeline changed the title Remove start page-related commands Remove start page-related commands and display logic Jul 26, 2021
@kimadeline kimadeline added the skip tests Updates to tests unnecessary label Jul 26, 2021
@kimadeline
Copy link
Author

whoops sorry @paulacamargo25 I don't know why it re-requested a review, I guess I shouldn't have used the back button or something 🙈

@karrtikr karrtikr removed the request for review from paulacamargo25 July 26, 2021 18:35
@kimadeline kimadeline merged commit 8086425 into microsoft:main Jul 26, 2021
@kimadeline kimadeline deleted the 16453-remove-start-page-commands branch July 26, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants