Skip to content

Update run failed tests with new codicon #17272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
luabud opened this issue Sep 3, 2021 · 3 comments
Closed

Update run failed tests with new codicon #17272

luabud opened this issue Sep 3, 2021 · 3 comments
Assignees
@luabud
Labels
area-testing feature-request Request for new features or functionality verified Verification succeeded
Milestone
September 2021

Comments

@luabud
Copy link
Member

luabud commented Sep 3, 2021

There's a new codicon for running failed items: microsoft/vscode-codicons#78
@luabud luabud added feature-request Request for new features or functionality needs PR area-testing labels Sep 3, 2021
@luabud luabud added this to the September 2021 milestone Sep 3, 2021
@luabud luabud self-assigned this Sep 3, 2021
@luabud luabud mentioned this issue Sep 3, 2021
Merged
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Sep 3, 2021
@luabud luabud closed this as completed Sep 3, 2021
@karthiknadig karthiknadig removed the triage-needed Needs assignment to the proper sub-team label Sep 7, 2021
@luabud luabud added the verification-needed Verification of issue is requested label Sep 28, 2021
@luabud
Copy link
Member Author

luabud commented Sep 28, 2021 •
edited
Loading

To verify this make sure you're using the latest updates from main (or use our build program by running the "Python: Switch to insiders weekly channel"). Then you can check if the new run all failed tests icon:

image

@IanMatthewHuff IanMatthewHuff removed the verification-needed Verification of issue is requested label Sep 28, 2021
@IanMatthewHuff
Copy link
Member

Looks good. Verified:
image

@brettcannon brettcannon added the verified Verification succeeded label Sep 28, 2021
@brettcannon
Copy link
Member

@IanMatthewHuff based on your message I assume you forgot to add the verified label, so I just went ahead and did it for you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luabud luabud

Labels
area-testing feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Milestone
September 2021
Development

No branches or pull requests
4 participants
@brettcannon @IanMatthewHuff @karthiknadig @luabud