Pylint not Running After December Update

[dchemishanov]

VS Code version

1.63.2

Extension version

2021.12.1559732655

OS type

Windows

OS version

Windows10 H1 Built 1943

Python distribution

Other

Python version

3.8.5

Language server

Default

Expected behaviour

The selected linter should've been ran and its settings in the settings.json file should've been respected.

Actual behaviour

Pylint is not ran, its settings are not respected, VSCode does not show pylint messages. Such exist as verified through the command line.

Steps to reproduce

I haven't tried to recreate it on another machine. My setup is:

• Windows 10
• WSL V1 with Ubuntu 18.04
• remote wsl extension
• pyenv python environment 3.8.5

After the december update of VSCode, might've been 1.63.1 even, the remote environment became completely unusable. VSC decided that it is github.dev or something and ran the workspace in partial mode. I deleted everything on the local os and in the WSL and reinstalled from scratch. Currently the environment is normal, but the python extension does not respect the choice of pylint as a linter and does not run it when I execute the "Run linter" command from the command palate.

Current settings.json on the remote environment:

{
    "workbench.startupEditor": "none",
    "editor.accessibilitySupport": "on",
    "python.analysis.autoImportCompletions": true,
    "python.analysis.autoSearchPaths": true,
    "python.analysis.completeFunctionParens": true,
    "python.analysis.useLibraryCodeForTypes": true,
    "python.formatting.provider": "black",
    "python.linting.enabled": true,
    "python.linting.lintOnSave": true,
    "python.linting.pylintEnabled": true,
    "python.linting.pylintUseMinimalCheckers": false,
    "python.linting.pylintArgs": [
        "--rcfile",
        "/mnt/c/Users/<username>/<project_name>/.vscode/.pylintrc"
    ]
    // "python.linting.pylintCategorySeverity.error": "Error",
    // "python.linting.pylintCategorySeverity.fatal": "Error",
    // "python.linting.pylintCategorySeverity.warning": "Warning",
    // "python.linting.pylintCategorySeverity.refactor": "Information",
    // "python.linting.pylintCategorySeverity.convention": "Information"
}

Logs

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[dchemishanov]

@isidorn

[isidorn]

@dchemishanov thanks for creating the issue, let's see if @luabud and the python team can help.

[brettcannon]

Can you share the logs from the "Python" channel of the Output Panel? That will show us what command the extension tried to run for Pylint and if there was any errors from that attempt.

[dchemishanov]

Can you share the logs from the "Python" channel of the Output Panel? That will show us what command the extension tried to run for Pylint and if there was any errors from that attempt.

Hi,

below is sample of the output with username and project redacted:

Experiment 'pythonaacf' is active
Experiment 'pythonTensorboardExperiment' is active
Experiment 'PythonPyTorchProfiler' is active
Experiment 'pythonDeprecatePythonPath' is active
> conda info --json
...
> ~/.pyenv/versions/3.8.5/envs/v_vinavil/bin/python ~/.vscode-server/extensions/ms-python.python-2021.12.1559732655/pythonFiles/testing_tools/run_adapter.py discover pytest -- --rootdir /mnt/c/Users/<username>/<project> -s --cache-clear --root-dir -p no:warnings /mnt/C/Users/<username>/<project>/
cwd: /mnt/c/Users/<username>/<project>
Starting Pylance language server.
[ERROR 2022-0-4 15:56:37.183]: Error discovering pytest tests:
 [r [Error]: ERROR: usage: run_adapter.py [options] [file_or_dir] [file_or_dir] [...]
run_adapter.py: error: unrecognized arguments: --root-dir
  inifile: None
  rootdir: /mnt/c/Users/<username>/<project>


Traceback (most recent call last):
  File "/home/<username>/.vscode-server/extensions/ms-python.python-2021.12.1559732655/pythonFiles/testing_tools/run_adapter.py", line 22, in <module>
    main(tool, cmd, subargs, toolargs)
  File "/home/<username>/.vscode-server/extensions/ms-python.python-2021.12.1559732655/pythonFiles/testing_tools/adapter/__main__.py", line 100, in main
    parents, result = run(toolargs, **subargs)
  File "/home/<username>/.vscode-server/extensions/ms-python.python-2021.12.1559732655/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 44, in discover
    raise Exception("pytest discovery failed (exit code {})".format(ec))
Exception: pytest discovery failed (exit code 4)

	at ChildProcess.<anonymous> (/home/<username>/.vscode-server/extensions/ms-python.python-2021.12.1559732655/out/client/extension.js:32:39076)
	at Object.onceWrapper (events.js:422:26)
	at ChildProcess.emit (events.js:315:20)
	at maybeClose (internal/child_process.js:1048:16)
	at Socket.<anonymous> (internal/child_process.js:439:11)
	at Socket.emit (events.js:315:20)
	at Pipe.<anonymous> (net.js:673:12)]
> ~/.pyenv/versions/3.8.5/envs/v_vinavil/bin/python ~/.vscode-server/extensions/ms-python.python-2021.12.1559732655/pythonFiles/testing_tools/run_adapter.py discover pytest -- --rootdir /mnt/c/Users/<username>/<project> -s --cache-clear --root-dir -p no:warnings /mnt/C/Users/<username>/<project>/
cwd: /mnt/c/Users/<username>/<project>
> ~/.pyenv/versions/3.8.5/envs/v_vinavil/bin/python -m pylint --rcfile /mnt/C/Users/<username>/<project>/.vscode/.pylintrc --msg-template='{line},{column},{category},{symbol}:{msg} --reports=n --output-format=text /mnt/c/Users/<username>/<project>/igor/src/<project>_igor/custom_driver/driver_execution.py
cwd: /mnt/c/Users/<username>/<project>
[ERROR 2022-0-4 15:56:38.880]: Error discovering pytest tests:
 [r [Error]: ERROR: usage: run_adapter.py [options] [file_or_dir] [file_or_dir] [...]
run_adapter.py: error: unrecognized arguments: --root-dir
  inifile: None
  rootdir: /mnt/c/Users/<username>/<project>


Traceback (most recent call last):
  File "/home/<username>/.vscode-server/extensions/ms-python.python-2021.12.1559732655/pythonFiles/testing_tools/run_adapter.py", line 22, in <module>
    main(tool, cmd, subargs, toolargs)
  File "/home/<username>/.vscode-server/extensions/ms-python.python-2021.12.1559732655/pythonFiles/testing_tools/adapter/__main__.py", line 100, in main
    parents, result = run(toolargs, **subargs)
  File "/home/<username>/.vscode-server/extensions/ms-python.python-2021.12.1559732655/pythonFiles/testing_tools/adapter/pytest/_discovery.py", line 44, in discover
    raise Exception("pytest discovery failed (exit code {})".format(ec))
Exception: pytest discovery failed (exit code 4)

	at ChildProcess.<anonymous> (/home/<username>/.vscode-server/extensions/ms-python.python-2021.12.1559732655/out/client/extension.js:32:39076)
	at Object.onceWrapper (events.js:422:26)
	at ChildProcess.emit (events.js:315:20)
	at maybeClose (internal/child_process.js:1048:16)
	at Socket.<anonymous> (internal/child_process.js:439:11)
	at Socket.emit (events.js:315:20)
	at Pipe.<anonymous> (net.js:673:12)]
##########Linting Output - pylint##########
> ~/.pyenv/versions/3.8.5/envs/v_vinavil/bin/python 
...
> ~/.pyenv/versions/3.8.5/envs/v_vinavil/bin/python -m pylint --rcfile /mnt/C/Users/<username>/<project>/.vscode/.pylintrc --msg-template='{line},{column},{category},{symbol}:{msg} --reports=n --output-format=text /mnt/c/Users/<username>/<project>/igor/src/<project>_igor/persistence/factories/device_custom_driver_inspection.py
cwd: /mnt/c/Users/<username>/<project>
> ~/.pyenv/versions/3.8.5/envs/v_vinavil/bin/python ~/.vscode-server/extensions/ms-python.python-2021.12.1559732655/pythonFiles/testing_tools/run_adapter.py discover pytest -- --rootdir /mnt/c/Users/<username>/<project> -s --cache-clear --root-dir -p no:warnings /mnt/C/Users/<username>/<project>/
cwd: /mnt/c/Users/<username>/<project>
[ERROR 2022-0-4 16:56:14.952]: Error discovering pytest tests:
 [r [Error]: ERROR: usage: run_adapter.py [options] [file_or_dir] [file_or_dir] [...]
run_adapter.py: error: unrecognized arguments: --root-dir

[brettcannon]

We seem to be running the command ~/.pyenv/versions/3.8.5/envs/v_vinavil/bin/python -m pylint --rcfile /mnt/C/Users/<username>/<project>/.vscode/.pylintrc --msg-template='{line},{column},{category},{symbol}:{msg} --reports=n --output-format=text /mnt/c/Users/<username>/<project>/igor/src/<project>_igor/persistence/factories/device_custom_driver_inspection.py on your behalf. If you run that from a terminal that lead to the output you would expect?

[dchemishanov]

We seem to be running the command ~/.pyenv/versions/3.8.5/envs/v_vinavil/bin/python -m pylint --rcfile /mnt/C/Users/<username>/<project>/.vscode/.pylintrc --msg-template='{line},{column},{category},{symbol}:{msg} --reports=n --output-format=text /mnt/c/Users/<username>/<project>/igor/src/<project>_igor/persistence/factories/device_custom_driver_inspection.py on your behalf. If you run that from a terminal that lead to the output you would expect?

When I run it, the command is not executing because the --msg-template option has no closing single quote...

[kimadeline]

Hi @dchemishanov, starting from the January release we won't use the --msg-template='{line},{column},{category},{symbol}:{msg} argument in the Python extension for VS Code anymore (#18068).

However, there might be an underlying problem anyway. For the missing quote it seems like it's only a stringification issue (we should probably fix it, feel free to file an issue about that), because linting works for me:

Can you try adding the missing quote and see what the command returns? Do you have a sample project I can use to try and replicate the issue?