-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Notify users to upgrade conda when applicable #20087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What's the activation for? Just for a terminal, or for running commands? If it's the former then Kartik has started to look into this and has an initial plan to try out. If it's the latter than we are moving to |
Its the latter |
Then the conda has asked us to have users (or us personally when we are so motivated) to file bugs at https://github.com/conda/conda/issues and work towards adopting Do you know what version of conda people who are having problems are running? We found a lot of users having issues were using versions like conda 4.8 which is nearly 3 years old. Once we asked them to upgrade (which no one actually balked at), the situation improved. |
No i don't |
I'm hoping for a solution as follows, i.e. unblock users without having to wait for for users to file a bug at our end to be notified of a solution
This way users are able to unblock themselves without having to reach out to us. |
We're working on a potentially new way to activate terminals. Until that's done there's no plan for an API (although if we do end up using the environment context API for terminals then everyone gets the activation for "free").
We are still waiting for conda to tell us what their support timelines are going to be. Once we have that we could potentially notify users that they are outside of support. But I'm not sure if we want to do that as it's not a guarantee things won't work, just that we don't make a guarantee things will work. This is why we don't tell e.g. Python 3.6 users they are unsupported even though debugpy doesn't work; if you just use the run button then everything works out fine. |
We've changed code for fetching environment variables to use |
Btw, I'm not able to reproduce this issue on SSH or WSL, if you can provide reproducible steps that would help investigate why |
@DonJayamanne 5:44:15.096: Failed to get activated conda env variables from Python for "Environment" Switching to pre-release version of Jupyter extension fixed the issue. Is the root cause related to the version of Conda or something else? Please advise. I would like to know so that I prevent this issue from happening again. |
We stop using |
Uh oh!
There was an error while loading. Please reload this page.
Conda activation failing for a number of users in Jupyter extension
Over the past few months I've been seing a lot of bugs filed by users with logs containing the following
These are either users on SSH, WSL, and even local
I understand that getting conda working for everyone isn't easy.
& Jupyter extension has code to work around some of the issues in Python extension as well.
I'd like to
Note: Today we don't have as many failures as we should because we have custom code in Jupyter extension that serves as a fall back when Python exesnion fails to activate the Conda enviornment.
https://github.com/DonJayamanne/vscode-jupyter/blob/main/src/platform/common/process/environmentActivationService.node.ts#L306
This is something I have already shared with @karrtikr @karthiknadig some time ago in a few meetings.
This will ensure more users will continue to have success with Conda envionments.
Else we'd have to continue to implement work arounds in Jupyter extension to keep resolving these activation issues, and reverting these changes would only result in breaking existing user.
Some related issues
I believe the soliution identified here #19965 (comment) would solve a large number of these issues (including WSL, SSH and the like). I.e. fall back to old actiavtion when
conda run
fails. However @karrtikr might have a better solution and more ideas on what could be improved.The text was updated successfully, but these errors were encountered: