forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
VIRTUAL_ENV_PROMPT is not respected by extension #22956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
author-verification-requested
Issues potentially verifiable by issue author
bug
Issue identified by VS Code Team member as probable bug
experimenting
Feature is part of an experiment
needs PR
Ready to be worked on
verified
Verification succeeded
Milestone
Comments
Output for
|
Typo on my part when making the issue - edited and fixed - the actual variable is VIRTUAL_ENV_PROMPT Trace level output:
.venv/bin/activate content
|
We can see from the logs that the addon does seem to identify
|
@Arnatious Let us know if you can verify it is fixed. |
wesm
pushed a commit
to posit-dev/positron
that referenced
this issue
Apr 5, 2024
…ython#23080) Closes microsoft/vscode-python#22956 Because we calculate `PS1` ourselves due to a limitation: microsoft/vscode-python#22078, this environment variable may not end up being respected as do not use `PS1`. This PR fixes it.
wesm
pushed a commit
to posit-dev/positron
that referenced
this issue
Apr 8, 2024
…ython#23080) Closes microsoft/vscode-python#22956 Because we calculate `PS1` ourselves due to a limitation: microsoft/vscode-python#22078, this environment variable may not end up being respected as do not use `PS1`. This PR fixes it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
author-verification-requested
Issues potentially verifiable by issue author
bug
Issue identified by VS Code Team member as probable bug
experimenting
Feature is part of an experiment
needs PR
Ready to be worked on
verified
Verification succeeded
Type: Bug
Using the latest prerelease of python to fix virtualenv activation being entirely broken:
Behaviour
Expected vs. Actual
VSCode terminals spawn with part of path
(.venv)
prepending prompt regardless of VIRTUAL_ENV_PROMPT. Example below with oh-my-zsh, agnoster theme. Worked correctly prior to 2024/02/22.Using prerelease extension version as automatic virutalenv activation stopped working entirely without it today.
Prompt should have been (otel-pypl-bridge-py3.9)
Steps to reproduce:
Diagnostic data
python.languageServer
setting: DefaultOutput for
Python
in theOutput
panel (View
→Output
, change the drop-down the upper-right of theOutput
panel toPython
)User Settings
Extension version: 2024.0.1
VS Code version: Code 1.85.2 (8b3775030ed1a69b13e4f4c628c612102e30a681, 2024-01-18T06:40:10.514Z)
OS version: Windows_NT x64 10.0.22621
Modes:
Remote OS version: Linux x64 5.4.152-4.x86_64
A/B Experiments
The text was updated successfully, but these errors were encountered: