forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Incorrect PS1 env being set for terminals, duplicated parenthesis #23184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'll add that it seems this version (2024.4.0) does not set the executable bit on the deactivate script which prevents deactivating the environment unless I do
This is happening in a remote dev container. Reverting to 2024.2.1 seems to fix this problem and the incorrect prompt. |
Thanks for filing issue! PR for the fix is on the way: #23201 |
anthonykim1
added a commit
that referenced
this issue
Apr 8, 2024
Duplicate #23193 |
anthonykim1
added a commit
to anthonykim1/vscode-python
that referenced
this issue
Apr 9, 2024
Resolves: microsoft#23193 microsoft#23184 Resolve duplicated (.venv) prompt for users terminal. Issue came from: microsoft#23080
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Uh oh!
There was an error while loading. Please reload this page.
Type: Bug
Behaviour
Version v2024.4.0 respects

VIRTUAL_ENV_PROMPT
, but at the same time tries to put in in(...)
, which leads to duplication:Steps to reproduce:
python -m venv .venv
source .venv/bin/activate
Select Interpreter
dropdownI tracked down the problem to
getPromptForEnv
insrc\client\terminals\envCollectionActivation\service.ts
, specifically this if statement:When

VIRTUAL_ENV_PROMPT
is(.venv)
, this results in((.venv) )
.Extension version: 2024.4.0
VS Code version: Code 1.87.2 (863d2581ecda6849923a2118d93a088b0745d9d6, 2024-03-08T15:20:17.278Z)
OS version: Windows_NT x64 10.0.22000
Modes:
Remote OS version: Linux x64 5.15.0-100-generic
Remote OS version: Linux x64 5.15.0-100-generic
Remote OS version: Linux x64 5.10.0-20-amd64
Remote OS version: Linux x64 5.15.0-100-generic
The text was updated successfully, but these errors were encountered: