Symbol navigation via ctrl-t does not work when the microsoft language server is enabled (jedi disabled)

[ogrisel]

Environment data

• VS Code version: 1.27.2
• Extension version (available under the Extensions sidebar): 2018.8.0
• OS and version: Ubuntu 16.04
• Python version (& distribution if applicable, e.g. Anaconda): 3.6 or 3.7 built from source
• Type of virtual environment used: virtualenv / python -m venv
• Relevant/affected Python packages and their versions: N/A

Steps to reproduce:

Disable jedi in settings.json. Here the full settings.json I used to make sure that this issue is not caused by a problem in my config:

{
    "python.jediEnabled": false
}

Then try with the following mixed Python/Cython/C/C++ code base:

$ git clone https://github.com/scikit-learn/scikit-learn
$ cd scikit-learn
$ code .

Then hit "ctrl-t" and type "KMeans" for instance.

Actual behavior

The ctrl-t menu is never populated as expected (it stays empty). I have the same problem with other symbols defined in this project (e.g. LogisticRegression, check_array...).

The "Analysing workspace, 1 item remaining..." message never goes away.

Weirdly enough, hitting "F12" on a Python symbol defined in the workspace can make VS code navigate to it successfully. It's just the ctrl-t symbol search menu that's broken.

Expected behavior

Being able to open the k_means_.py file from the project folder in the workspace to navigate to the definition of the KMeans class.

Logs

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

Starting Microsoft Python language server.
Initializing for /volatile/ogrisel/.virtualenvs/py36/bin/python
##########Linting Output - pylint##########
[snip]

[Error - 09:52:35] Request workspace/symbol failed.
  Message: Object reference not set to an instance of an object.
  Code: -32000 
[object Object]
[Error - 09:52:36] Request workspace/symbol failed.
  Message: Object reference not set to an instance of an object.
  Code: -32000 
[object Object]
...

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)

[nothing]

Also note that jedi has no problem with this workspace.

[brettcannon]

I will try to verify.

[brettcannon]

This is triggering an error, so I have reported it upstream.

[ogrisel]

@brettcannon I tried with today's release (2018.10.0) of the VSCode Python extension, I got the message telling me the language server was updated but I still cannot get ctrl-t to work when working on a local clone of the https://github.com/scikit-learn/scikit-learn repo.

With the new version update (.vscode/extensions/ms-python.python-2018.10.0/languageServer.0.1.60/) that arguably includes @MikhailArkhipov's fix from #137) I no longer the Code: -32000 error message but instead I can see the Microsoft.Python.LanguageServer process using 100% of one of my CPUs forever (in htop).

@MikhailArkhipov is there any command to launch from the command line that could help get a more verbose diagnostics on what's going on?

More importantly the Go to Symbol in Workspace menu is still never populated (even after waiting for 10 minutes).

[ogrisel]

Actually after a while I got the following error messages in the output panel of VS Code:

Starting Microsoft Python language server.
Microsoft Python Language Server version 0.1.60.0
Initializing for /opt/venvs/py37/bin/python
[Error - 12:01:32 PM] Request workspace/symbol failed.
  Message: Object reference not set to an instance of an object.
  Code: -32000 
   at Microsoft.Python.LanguageServer.Implementation.Server.<>c__DisplayClass133_0.<GetModuleVariables>b__4(ILocationInfo l)
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
   at System.Linq.Enumerable.Any[TSource](IEnumerable`1 source, Func`2 predicate)
   at Microsoft.Python.LanguageServer.Implementation.Server.<>c__DisplayClass133_0.<GetModuleVariables>b__2(IMemberResult m)
   at System.Linq.Enumerable.WhereEnumerableIterator`1.MoveNext()
   at System.Linq.Enumerable.EnumerablePartition`1.ToList()
   at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source)
   at Microsoft.Python.LanguageServer.Implementation.Server.GetModuleVariablesAsync(ProjectEntry entry, GetMemberOptions opts, String prefix, Int32 timeout, CancellationToken token)
   at Microsoft.Python.LanguageServer.Implementation.Server.WorkspaceSymbols(WorkspaceSymbolParams params, CancellationToken cancellationToken)
   at Microsoft.Python.LanguageServer.Implementation.LanguageServer.WorkspaceSymbols(JToken token, CancellationToken cancellationToken)

[same error repeated many times]

[ogrisel]

I opened microsoft/python-language-server#378 upstream.

[ogrisel]

Now that microsoft/python-language-server#378 (@jakebailey and @MikhailArkhipov) is closed, I have tried again today with Python extension 2018.11.0 and languageServer 0.1.65 and I no longer get the error message (or any languageServer output) in the output panel of vscode but the symbol navigation still does not work:

same behavior as before when I do a ctrl-T + name of a scikit-learn class such as KMeans or any other class or function name.

The languageServer is still using 100% of one or 2 CPUs in the background (for several minutes).

On the same git clone, jedi / ctags indexes the symbols much faster (less than a minute I would say) and navigation works as expected.