Skip to content

Navigation from Test Explorer to code #4278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
d3r3kk opened this issue Feb 5, 2019 · 3 comments
Closed

Navigation from Test Explorer to code #4278

d3r3kk opened this issue Feb 5, 2019 · 3 comments
Assignees
Labels
area-testing feature-request Request for new features or functionality

Comments

@d3r3kk
Copy link

d3r3kk commented Feb 5, 2019

Double-clicking an element in the Test Explorer view will navigate the user to the file/line number in the editor that holds the definition of that Test Explorer element.

  • File - open the file, place the cursor at the top.
  • Suite - open the file containing the suite, place the cursor at the beginning of the line where the class (suite) is declared.
  • Function - open the file containing the function, place the cursor at the beginning of the line where the function is declared.

This may require extending the model we use for our tests a bit, or extending the API we make available to the TreeViewHandler. Today, we can run a specific test can we navigate to it from anyplace? If there is a trivial or well known call that can do this today, it may lower this task's complexity a bit!

Test for completion:

  • Double-clicking on a file in the test explorer view puts my cursor at line 1, col 1 of that file.
  • Double-clicking on a suite in the test explorer view puts my cursor at the line the suite/class is declared, col 1.
  • Double-clicking on a function in the test explorer view puts my cursor at the line the function is declared, col 1.
@ghost ghost added the triage-needed Needs assignment to the proper sub-team label Feb 5, 2019
@d3r3kk d3r3kk added area-testing needs PR feature-request Request for new features or functionality labels Feb 5, 2019
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Feb 5, 2019
@d3r3kk d3r3kk added this to the 2019, week 5 - Jan Sprint 3 milestone Feb 5, 2019
@d3r3kk
Copy link
Author

d3r3kk commented Feb 5, 2019

Code Lense provider has this today, we will need to make use of it in a new API that we will share with the Test Explorer.

@karrtikr
Copy link

karrtikr commented Feb 9, 2019

This is no longer done by Double clicking , but by clicking Open icon. Also the cursor does not move, but the focus is changed to the correct place. If this is the expected behavior @DonJayamanne , go ahead and close it.

@karrtikr karrtikr closed this as completed Feb 9, 2019
@ghost ghost removed the needs PR label Feb 9, 2019
@DonJayamanne
Copy link

Let's get clarification from PMs

@DonJayamanne DonJayamanne reopened this Feb 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

3 participants