Closed
Description
Environment data
- VSCode Version: Code - Insiders 1.20.0-insider (f911534, 2017-12-22T06:14:07.615Z)
- OS Version: Linux x64 4.9.73-1-lts
- Extensions:
| Extension | Author (truncated) | Version |
|---|---|---|
| python | ms- | 0.9.1 |
Python Version: Python 3.6.4
OS and version: Arch (Rolling, Linux x64 4.9.73-1-lts)
Reproduces without extensions: No
Actual behavior
Syntax error thrown when renaming variable (refactoring)
Rename fails
Expected behavior
Rename succeeds
Steps to reproduce:
- testcase.zip
- Extract test case. (From ms-python tutorial!)
- pipenv install; pipenv install --dev
- pipenv shell
- Open VSCode
- Open standardplot.py
- Select 'x' and try to rename (F2) to 'X' (ie capital X)
Comment
Might be a problem with Astroid? But tests for Astroid 1.6.0 all passing. No matching issues.
No reported issues for current version of rope match issue.
Logs
Output from Python output panel
Refactor failed. Syntax error in file <.venv/lib/python3.6/site-packages/astroid/tests/testdata/python2/data/module.py> line <32>: invalid syntax
[<FrameSummary file refactor.py, line 271 in watch>, <FrameSummary file refactor.py, line 252 in _process_request>, <FrameSummary file refactor.py, line 183 in _rename>, <FrameSummary file refactor.py, line 94 in refactor>, <FrameSummary file refactor.py, line 116 in onRefactor>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/rename.py, line 97 in get_changes>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/rename.py, line 195 in rename_in_module>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/occurrences.py, line 78 in find_occurrences>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/occurrences.py, line 215 in __call__>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/utils/__init__.py, line 12 in _wrapper>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/occurrences.py, line 137 in get_pyname>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/utils/__init__.py, line 12 in _wrapper>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/occurrences.py, line 374 in name_finder>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/utils/__init__.py, line 12 in _wrapper>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/occurrences.py, line 402 in pymodule>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/project.py, line 116 in get_pymodule>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/pycore.py, line 142 in resource_to_pyobject>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/pycore.py, line 255 in get_pymodule>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/pyobjectsdef.py, line 162 in __init__>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/pyobjectsdef.py, line 191 in _init_source>]
Output from Console window (Help->Developer Tools menu)
Refactor failed. Syntax error in file <.venv/lib/python3.6/site-packages/astroid/tests/testdata/python2/data/module.py> line <32>: invalid syntax
[<FrameSummary file refactor.py, line 271 in watch>, <FrameSummary file refactor.py, line 252 in _process_request>, <FrameSummary file refactor.py, line 183 in _rename>, <FrameSummary file refactor.py, line 94 in refactor>, <FrameSummary file refactor.py, line 116 in onRefactor>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/rename.py, line 97 in get_changes>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/rename.py, line 195 in rename_in_module>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/occurrences.py, line 78 in find_occurrences>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/occurrences.py, line 215 in __call__>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/utils/__init__.py, line 12 in _wrapper>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/occurrences.py, line 137 in get_pyname>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/utils/__init__.py, line 12 in _wrapper>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/occurrences.py, line 374 in name_finder>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/utils/__init__.py, line 12 in _wrapper>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/refactor/occurrences.py, line 402 in pymodule>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/project.py, line 116 in get_pymodule>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/pycore.py, line 142 in resource_to_pyobject>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/pycore.py, line 255 in get_pymodule>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/pyobjectsdef.py, line 162 in __init__>, <FrameSummary file /home/matt/Dev/VSCodePython/.venv/lib/python3.6/site-packages/rope/base/pyobjectsdef.py, line 191 in _init_source>]
e.doShow @ messageService.ts:126