Upstream indentation regexes to VS Code #6520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

7 tasks

brettcannon opened this issue Jul 10, 2019 · 2 comments

Labels

area-formatting debt

Member

brettcannon commented Jul 10, 2019

Once #6497 lands we should upstream the appropriate regexes to https://github.com/microsoft/vscode/blob/master/extensions/python/language-configuration.json and delete https://github.com/microsoft/vscode/blob/master/extensions/python/src/pythonMain.ts so that all Python users benefit.

Steps

Land Add regex to dedent else and friends #6497
Write smoke tests to make sure upstream doesn't regress
Upstream regexes to https://github.com/microsoft/vscode/blob/master/extensions/python/language-configuration.json
Delete https://github.com/microsoft/vscode/tree/master/extensions/python/.vscode
Delete https://github.com/microsoft/vscode/tree/master/extensions/python/src
Delete https://github.com/microsoft/vscode/blob/master/extensions/python/tsconfig.json
Delete our own code and tests

The text was updated successfully, but these errors were encountered:

brettcannon added needs PR debt area-formatting labels

Member Author

brettcannon commented Jul 10, 2019

/cc @kimadeline

kimadeline mentioned this issue

Add regex to dedent else and friends #6497

Merged

4 tasks

Member

luabud commented Sep 15, 2020

Closing as stale.

luabud closed this as completed

ghost removed the needs PR label

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.