Skip to content

Restore skipped venv tests. #8826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ericsnowcurrently opened this issue Nov 27, 2019 · 4 comments
Closed

Restore skipped venv tests. #8826

ericsnowcurrently opened this issue Nov 27, 2019 · 4 comments
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Milestone
2019 December Spr...

Comments

@ericsnowcurrently
Copy link

For #8804 we skipped some of the tests related to venv discovery (see #8810). These tests need to be re-enabled and fixed.

"Interpreters - Workspace VirtualEnv Service"
@ericsnowcurrently ericsnowcurrently added needs PR debt Covers everything internal: CI, testing, refactoring of the codebase, etc. important Issue identified as high-priority labels Nov 27, 2019
@ericsnowcurrently ericsnowcurrently mentioned this issue Nov 27, 2019
Closed
@ericsnowcurrently
Copy link
Author

@luabud

I'm pretty sure these were already failing sporadically (checked against master before any of my changes). So fixing this isn't so critical. We could punt it back out of the sprint...

@karthiknadig karthiknadig added cause-CI/CD and removed important Issue identified as high-priority unplanned labels Nov 27, 2019
@karthiknadig karthiknadig removed this from the 2019 November Sprint 2 milestone Nov 27, 2019
@DonJayamanne
Copy link

(checked against master before any of my

Not sure about this, as it would have caused insiders builds to not get created before FS changes, but thats not true.
The root cause is the IFileSystem is returning false even when a file exists.

Basically conda and venv environments do not work at all anymore.
I'd consider this a P0 and restoring the venv tests.

@luabud @karthiknadig /cc

@DonJayamanne
Copy link

Cause #8890

@karthiknadig karthiknadig added this to the 2019 December Sprint 1 milestone Dec 4, 2019
@ericsnowcurrently
Copy link
Author

FYI, with the fix for #8890 these tests still fail (timing out).

@ghost ghost removed the needs PR label Dec 10, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Dec 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
debt Covers everything internal: CI, testing, refactoring of the codebase, etc.
Projects
None yet
Milestone
2019 December Sprint 1
Development

No branches or pull requests
4 participants
@ericsnowcurrently @DonJayamanne @karthiknadig @karrtikr