Skip to content

Skip problematic tests. #8810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Conversation

ericsnowcurrently
Copy link

For #8804.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [ ] Has a news entry file (remember to thank yourself!)
  • [ ] Appropriate comments and documentation strings in the code
  • [ ] Has sufficient logging.
  • [ ] Has telemetry for enhancements.
  • [ ] Unit tests & system/integration tests are added/updated
  • [ ] Test plan is updated as appropriate
  • [ ] package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • [ ] The wiki is updated with any design decisions/details.

@ericsnowcurrently ericsnowcurrently added the no-changelog No news entry required label Nov 26, 2019
@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

Merging #8810 into master will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8810      +/-   ##
==========================================
+ Coverage   58.37%   58.66%   +0.29%     
==========================================
  Files         526      526              
  Lines       27180    27180              
  Branches     4039     4044       +5     
==========================================
+ Hits        15866    15946      +80     
+ Misses      10443    10363      -80     
  Partials      871      871
Impacted Files Coverage Δ
src/client/language/characters.ts 37.14% <0%> (+2.85%) ⬆️
src/client/common/utils/version.ts 81.48% <0%> (+3.7%) ⬆️
src/client/providers/providerUtilities.ts 88.88% <0%> (+5.55%) ⬆️
src/client/datascience/cellFactory.ts 71.25% <0%> (+12.5%) ⬆️
src/client/api.ts 93.33% <0%> (+13.33%) ⬆️
...cience/jupyter/jupyterDebuggerNotInstalledError.ts 66.66% <0%> (+16.66%) ⬆️
src/client/common/utils/icons.ts 100% <0%> (+16.66%) ⬆️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 80% <0%> (+20%) ⬆️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 75% <0%> (+25%) ⬆️
src/client/formatters/serviceRegistry.ts 100% <0%> (+25%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57df230...5295af4. Read the comment docs.

@brettcannon brettcannon merged commit c5f7766 into microsoft:master Nov 27, 2019
@ericsnowcurrently ericsnowcurrently deleted the fix-ci branch November 27, 2019 15:15
@lock lock bot locked as resolved and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants