-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Activate if workspace have Python-related files #10856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10856 +/- ##
==========================================
- Coverage 60.69% 60.66% -0.03%
==========================================
Files 580 580
Lines 31512 31525 +13
Branches 4480 4479 -1
==========================================
- Hits 19125 19124 -1
- Misses 11419 11429 +10
- Partials 968 972 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Can you please include all the files mentioned the issue, including comments. This for instance.
Also please thank yourself in the news entry. :)
Kudos, SonarCloud Quality Gate passed!
|
There's so much stuff in Python community 😆 |
@lengthmin Thank you for the updates. We might want to wrap this in an experiment. See discussion on #4765. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please only update for pyproject.toml
.
@brettcannon it seem that this feature has already merged into main branch should I close this pr? |
Sorry, I forgot we put that change in already. Yeah, unfortunately we have to balance triggering the extension with the fact that a lot of people only use Python occasionally and thus don't want to have it launch just because they run Python once every two months or something. Thanks for trying, though. |
close: #4765
For #
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).