Skip to content

Ensures file paths are properly encoded when passing them as arguments to linters. #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 22, 2018

Conversation

DonJayamanne
Copy link

Fixes #199

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Mar 22, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@5416af2). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1155   +/-   ##
=========================================
  Coverage          ?   71.95%           
=========================================
  Files             ?      260           
  Lines             ?    11905           
  Branches          ?     2112           
=========================================
  Hits              ?     8566           
  Misses            ?     3213           
  Partials          ?      126
Impacted Files Coverage Δ
src/client/linters/mypy.ts 84.61% <100%> (ø)
src/client/linters/prospector.ts 80% <100%> (ø)
src/client/linters/pylint.ts 98.36% <100%> (ø)
src/client/linters/flake8.ts 100% <100%> (ø)
src/client/linters/pep8.ts 100% <100%> (ø)
src/client/linters/pylama.ts 92.85% <100%> (ø)
src/client/linters/pydocstyle.ts 95.23% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5416af2...df9f65e. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 60fec3a into microsoft:master Mar 22, 2018
@DonJayamanne DonJayamanne deleted the issue199ProspectorPath branch June 20, 2018 03:19
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prospector gets file paths wrong
2 participants