Skip to content

Skip flaky testing framework discovery against actual python process test #11635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2020
Merged

Skip flaky testing framework discovery against actual python process test #11635

merged 2 commits into from
May 7, 2020

Conversation

karrtikr
Copy link

@karrtikr karrtikr commented May 6, 2020

For #11634

@karrtikr karrtikr added the no-changelog No news entry required label May 6, 2020
ericsnowcurrently
ericsnowcurrently approved these changes May 6, 2020
View reviewed changes
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once you add the comment I mentioned.

(I'm approving the PR, but please address my comment before merging.)

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.7% 0.7% Duplication

@karrtikr karrtikr merged commit 39e9448 into microsoft:master May 7, 2020
@karrtikr karrtikr deleted the skiptest branch May 7, 2020 07:43
@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

@karthiknadig karthiknadig karthiknadig approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karrtikr @ericsnowcurrently @karthiknadig