Skip to content

Remove DebugAdapterNewPtvsd and DebugAdapterDescriptorFactory experiment. #11769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 14, 2020
Merged

Remove DebugAdapterNewPtvsd and DebugAdapterDescriptorFactory experiment. #11769

merged 6 commits into from
May 14, 2020

Conversation

karthiknadig
Copy link
Member

For #7136

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@karthiknadig karthiknadig added the no-changelog No news entry required label May 12, 2020
@codecov-io
Copy link

codecov-io commented May 12, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (logging-changes-and-drop-old-debugger@2dd69fe). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                           Coverage Diff                            @@
##             logging-changes-and-drop-old-debugger   #11769   +/-   ##
========================================================================
  Coverage                                         ?   60.84%           
========================================================================
  Files                                            ?      620           
  Lines                                            ?    33764           
  Branches                                         ?     4762           
========================================================================
  Hits                                             ?    20544           
  Misses                                           ?    12213           
  Partials                                         ?     1007

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2dd69fe...d55a32b. Read the comment docs.

@karthiknadig
Copy link
Member Author

I still need to remove this from package json and experiments json.

ericsnowcurrently
ericsnowcurrently approved these changes May 14, 2020
View reviewed changes
Copy link

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FYI, only one of the comments matters (a typo). The others are just commentary. 😄

src/test/debugger/attach.ptvsd.test.ts

const launchResolver = TypeMoq.Mock.ofType<IDebugConfigurationResolver<LaunchRequestArguments>>();
const attachResolver = new AttachConfigurationResolver(
workspaceService.object,
documentManager.object,
platformService.object,
configurationService.object,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I still think we should require trailing commas (in the tslint and prettier configs). Then we would avoid this sort of churn in PRs/commit history (and it's less annoying when editing code).

karrtikr
karrtikr approved these changes May 14, 2020
View reviewed changes
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just make sure you search the string "DebugAdapterDescriptorFactory" & "DebugAdapterNewPtvsd" if you haven't already. LGTM otherwise

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@karthiknadig karthiknadig marked this pull request as ready for review May 14, 2020 21:54
@karthiknadig karthiknadig merged commit 982051d into microsoft:logging-changes-and-drop-old-debugger May 14, 2020
@karthiknadig karthiknadig deleted the remove-ptvsd-experiments branch May 14, 2020 23:17
karrtikr
karrtikr reviewed May 15, 2020
View reviewed changes
experiments.json
"min": 0,
"max": 100
},
{
Copy link

@karrtikr karrtikr May 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait I just realized removing these from experiments.json will opt users out of experiment. @karthiknadig

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change hasn't landed in master, so we can restore experiments.json😅

karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Jun 17, 2020
@karthiknadig
Remove DebugAdapterNewPtvsd and DebugAdapterDescriptorFactory experim…
4a6dba0 
…ent. (microsoft#11769)

* Remove DebugAdapterNewPtvsd and DebugAdapterDescriptorFactory experiment.

* Fix tests

* Remove experiments from json files
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Jun 18, 2020
@karthiknadig
Remove DebugAdapterNewPtvsd and DebugAdapterDescriptorFactory experim…
650e4a9 
…ent. (microsoft#11769)

* Remove DebugAdapterNewPtvsd and DebugAdapterDescriptorFactory experiment.

* Fix tests

* Remove experiments from json files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karrtikr karrtikr karrtikr approved these changes

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees
No one assigned
Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karthiknadig @codecov-io @ericsnowcurrently @karrtikr