-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add restart language server command #12952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
command name LGTM |
@jakebailey Oh I just noticed you're on the language server team, never mind me then. You got this :) |
8cb4d2a
to
8b28240
Compare
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #12952 +/- ##
==========================================
- Coverage 59.81% 59.78% -0.04%
==========================================
Files 670 670
Lines 37163 37183 +20
Branches 5264 5265 +1
==========================================
- Hits 22230 22228 -2
- Misses 13805 13824 +19
- Partials 1128 1131 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For #3073
Uses the existing language server restarting mechanism, which is already used for things like interpreter changes and such.
Has sufficient logging.Has telemetry for enhancements.Test plan is updated as appropriate.package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).The wiki is updated with any design decisions/details.