Skip to content

Hide Jedi flag #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 20, 2018
Merged

Conversation

DonJayamanne
Copy link

Fixes #1439

This pull request:

  • Has a title summarizes what is changing
  • [n/a] Includes a news entry file (remember to thank yourself!)
  • [n/a] Has unit tests & code coverage is not adversely affected (within reason)
  • [n/a] Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • [n/a] Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Apr 20, 2018

Codecov Report

Merging #1443 into master will decrease coverage by 46.45%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1443       +/-   ##
===========================================
- Coverage   70.93%   24.47%   -46.46%     
===========================================
  Files         271      271               
  Lines       12529    12529               
  Branches     2228     2228               
===========================================
- Hits         8887     3067     -5820     
- Misses       3499     9462     +5963     
+ Partials      143        0      -143
Impacted Files Coverage Δ
src/client/debugger/ProxyCommands.ts 0% <0%> (-100%) ⬇️
src/client/linters/linterInfo.ts 5.4% <0%> (-94.6%) ⬇️
src/client/common/idDispenser.ts 7.14% <0%> (-92.86%) ⬇️
src/client/language/tokenizer.ts 4.4% <0%> (-92.4%) ⬇️
src/client/debugger/DebugClients/helper.ts 3.84% <0%> (-92.31%) ⬇️
src/client/formatters/lineFormatter.ts 7.75% <0%> (-91.48%) ⬇️
src/client/language/characterStream.ts 4.41% <0%> (-91.18%) ⬇️
...nittests/common/testVisitors/resultResetVisitor.ts 9.37% <0%> (-90.63%) ⬇️
...nt/unittests/common/services/testResultsService.ts 4.28% <0%> (-90%) ⬇️
...lient/unittests/unittest/services/parserService.ts 9.09% <0%> (-88.64%) ⬇️
... and 192 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0e83e9...20c1141. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 208e603 into microsoft:master Apr 20, 2018
@DonJayamanne DonJayamanne deleted the issue1439HideJedi branch June 20, 2018 03:14
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide the python.jediEnabled flag
2 participants