-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Prompt to launch TensorBoard when active Python file or ipynb contains a tensorboard import #14884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
switch (selection) { | ||
case yes: | ||
await this.commandManager.executeCommand(Commands.LaunchTensorBoard); | ||
await this.disablePrompt(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per @jmew if the user selects 'yes', we will disable the prompt for the current session only, and continue to show the prompt on the next session where the trigger conditions are met, until the user selects 'doNotAskAgain'.
Codecov Report
@@ Coverage Diff @@
## main #14884 +/- ##
=======================================
Coverage 65% 65%
=======================================
Files 551 554 +3
Lines 25889 26091 +202
Branches 3672 3702 +30
=======================================
+ Hits 16902 17071 +169
- Misses 8294 8331 +37
+ Partials 693 689 -4
|
Co-authored-by: Kim-Adeline Miguel <[email protected]>
…o tensorboard-imports
…code-python into tensorboard-imports
For #14883
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).