Skip to content

Prompt to launch TensorBoard when active Python file or ipynb contains a tensorboard import #14884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 9, 2020

Conversation

joyceerhl
Copy link

For #14883

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

switch (selection) {
case yes:
await this.commandManager.executeCommand(Commands.LaunchTensorBoard);
await this.disablePrompt();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per @jmew if the user selects 'yes', we will disable the prompt for the current session only, and continue to show the prompt on the next session where the trigger conditions are met, until the user selects 'doNotAskAgain'.

@codecov-io
Copy link

codecov-io commented Dec 4, 2020

Codecov Report

Merging #14884 (414d699) into main (43d3f8e) will increase coverage by 0%.
The diff coverage is 86%.

@@           Coverage Diff           @@
##            main   #14884    +/-   ##
=======================================
  Coverage     65%      65%            
=======================================
  Files        551      554     +3     
  Lines      25889    26091   +202     
  Branches    3672     3702    +30     
=======================================
+ Hits       16902    17071   +169     
- Misses      8294     8331    +37     
+ Partials     693      689     -4     
Impacted Files Coverage Δ
src/client/telemetry/importTracker.ts 31% <75%> (+11%) ⬆️
src/client/tensorBoard/tensorBoardImportTracker.ts 88% <88%> (ø)
src/client/activation/node/analysisOptions.ts 55% <0%> (-16%) ⬇️
.../pythonEnvironments/common/externalDependencies.ts 73% <0%> (-5%) ⬇️
src/client/activation/jedi/languageServerProxy.ts 25% <0%> (-2%) ⬇️
src/client/activation/node/languageServerProxy.ts 25% <0%> (-2%) ⬇️
src/client/pythonEnvironments/legacyIOC.ts 35% <0%> (-1%) ⬇️
...client/common/application/debugSessionTelemetry.ts 20% <0%> (-1%) ⬇️
...t/activation/languageServer/languageServerProxy.ts 90% <0%> (-1%) ⬇️
...ent/pythonEnvironments/discovery/locators/index.ts 84% <0%> (-1%) ⬇️
... and 15 more

@karrtikr karrtikr removed the request for review from kimadeline December 4, 2020 19:37
@karrtikr karrtikr assigned karrtikr and unassigned kimadeline Dec 4, 2020
@karrtikr karrtikr self-requested a review December 4, 2020 20:11
@joyceerhl joyceerhl merged commit 6d205f4 into main Dec 9, 2020
@joyceerhl joyceerhl deleted the tensorboard-imports branch December 9, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants