-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Update Simplified Chinese translation #14997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update Simplified Chinese translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
cc @luabud @brettcannon Should we merge this?
Any updates? |
@FiftysixTimes7 can you resolve the merge conflicts? |
@brettcannon Conflicts are resolved! Sorry for not marking it as resolved initially. |
Codecov Report
@@ Coverage Diff @@
## main #14997 +/- ##
======================================
Coverage 65% 65%
======================================
Files 560 560
Lines 26362 26362
Branches 3747 3747
======================================
Hits 17174 17174
Misses 8494 8494
Partials 694 694 |
Thanks! |
@FiftysixTimes7 Can you please verify the extension loads correctly when using Chinese? |
I can verify it works for me. |
@karrtikr Yeah, it works well :) |
@FiftysixTimes7 some of those, like "Find All References" come from VS Code and not us. The "Run Current File in Interactive Window" is us and it might be a bug in the code that it isn't being translated. Would be willing to either try and find the bug or at least open an issue for us to fix it? |
Actually "Run Current File in Interactive Window" comes from the Jupyter extension, so you can look at https://github.com/microsoft/vscode-jupyter for that text. |
Thanks for tracking down the issue! |
@FiftysixTimes7 yes, please open a new issue. |
For #14997
[x] Appropriate comments and documentation strings in the code.[x] Has sufficient logging.[x] Has telemetry for enhancements.[x] Unit tests & system/integration tests are added/updated.[x] Test plan is updated as appropriate.[x]package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).[x] The wiki is updated with any design decisions/details.