Skip to content

Update Simplified Chinese translation #14997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2021
Merged

Update Simplified Chinese translation #14997

merged 3 commits into from
Jan 12, 2021

Conversation

FiftysixTimes7
Copy link

For #14997

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • [x] Appropriate comments and documentation strings in the code.
  • [x] Has sufficient logging.
  • [x] Has telemetry for enhancements.
  • [x] Unit tests & system/integration tests are added/updated.
  • [x] Test plan is updated as appropriate.
  • [x] package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • [x] The wiki is updated with any design decisions/details.

Update Simplified Chinese translation
@ghost
Copy link

ghost commented Dec 17, 2020

CLA assistant check
All CLA requirements met.

Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
cc @luabud @brettcannon Should we merge this?

@ddarfantasy
Copy link

Any updates?

@brettcannon brettcannon reopened this Jan 11, 2021
@github-actions github-actions bot requested a review from karrtikr January 11, 2021 17:47
@brettcannon
Copy link
Member

@FiftysixTimes7 can you resolve the merge conflicts?

@FiftysixTimes7
Copy link
Author

@brettcannon Conflicts are resolved! Sorry for not marking it as resolved initially.

@codecov-io
Copy link

Codecov Report

Merging #14997 (275bd75) into main (ef3fe4f) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #14997   +/-   ##
======================================
  Coverage     65%      65%           
======================================
  Files        560      560           
  Lines      26362    26362           
  Branches    3747     3747           
======================================
  Hits       17174    17174           
  Misses      8494     8494           
  Partials     694      694           

@brettcannon brettcannon merged commit e61e08e into microsoft:main Jan 12, 2021
@brettcannon
Copy link
Member

Thanks!

@karrtikr
Copy link

@FiftysixTimes7 Can you please verify the extension loads correctly when using Chinese?

@karrtikr
Copy link

I can verify it works for me.

@FiftysixTimes7
Copy link
Author

@karrtikr Yeah, it works well :)
But some commands seem unavailable to be translated, such as these 2 commands in the right-click menu:
屏幕截图 2021-01-13 162416
And everything in the settings panel...
If these can be translated, I'm willing to help :)

@brettcannon
Copy link
Member

@FiftysixTimes7 some of those, like "Find All References" come from VS Code and not us. The "Run Current File in Interactive Window" is us and it might be a bug in the code that it isn't being translated. Would be willing to either try and find the bug or at least open an issue for us to fix it?

@karrtikr
Copy link

Actually "Run Current File in Interactive Window" comes from the Jupyter extension, so you can look at https://github.com/microsoft/vscode-jupyter for that text.

@FiftysixTimes7
Copy link
Author

Thanks for tracking down the issue!
Time permitting, I'm ready to translate the Jupyter extension too :)

@FiftysixTimes7
Copy link
Author

FiftysixTimes7 commented Jan 22, 2021

I think I've found an issue:
图片
I've translated "StartPage.*", but it seems that the translation isn't displayed.
Do I need to open another issue?

@brettcannon
Copy link
Member

@FiftysixTimes7 yes, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants