Skip to content

Re-enable localization on the start page. #15297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 2, 2021
Merged

Re-enable localization on the start page. #15297

merged 3 commits into from
Feb 2, 2021

Conversation

ericsnowcurrently
Copy link

@ericsnowcurrently ericsnowcurrently commented Feb 2, 2021 •
edited
Loading

(for #15232)

Localization was accidentally disabled in #14447 (October) when we split out the Jupyter extension.

@ericsnowcurrently ericsnowcurrently added the skip tests Updates to tests unnecessary label Feb 2, 2021
@ericsnowcurrently
Copy link
Author

Thanks @kimadeline for the clear diagnosis on #15232! It would have taken much longer to fix this otherwise.

@karthiknadig
Copy link
Member

Great work @kimadeline

@ericsnowcurrently ericsnowcurrently merged commit 62b0c6d into microsoft:main Feb 2, 2021
@ericsnowcurrently ericsnowcurrently deleted the fix-15232-start-page-translation branch February 2, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@kimadeline kimadeline kimadeline approved these changes

Assignees

@ericsnowcurrently ericsnowcurrently

Labels
skip tests Updates to tests unnecessary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsnowcurrently @karthiknadig @kimadeline