Don't outdent on enter after raise with arguments #15516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the behaviour of pressing enter after a raise statement
which involves an explicit value so that the cursor position is no
longer outdented. Previously this worked well for things like:
raise
raise e
but less well for things like:
raise Exception(|)
which wouuld end up like:
raise Exception(
|)
With this change applied the latter case will end up like:
raise Exception(
|
)
which matches the behaviour of 'return'. The first case (without
a value) is unaffected, though the case of:
raise e
will, just like 'return' now require the user to explicitly
outdent after pressing enter. It is expected that this is an
acceptable trade-off, especially as it is already the case for
return statements.
Fixes microsoft#10583.
PeterJCLaw
force-pushed
the
fix-10583-no-outdent-on-raise
branch
from
f001243 to
6967ff2
Compare
Codecov Report
@@ Coverage Diff @@
## main #15516 +/- ##
======================================
Coverage 65% 65%
======================================
Files 561 561
Lines 27031 27031
Branches 3923 3923
======================================
Hits 17587 17587
Misses 8705 8705
Partials 739 739
|
karthiknadig
approved these changes
Mar 3, 2021
karrtikr
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behaviour of pressing enter after a raise statement which involves an explicit value so that the cursor position is no longer outdented. Previously this worked well for things like:
but less well for things like:
which wouuld end up like:
With this change applied the latter case will end up like:
which matches the behaviour of 'return'. The first case (without
a value) is unaffected, though the case of:
will, just like 'return' now require the user to explicitly outdent after pressing enter. It is expected that this is an acceptable trade-off, especially as it is already the case for return statements.
Fixes #10583.