Block on displaying selected interpreter in the status bar on startup #15971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrtikr
force-pushed
the
fs
branch
2 times, most recently
from
87d2ecc to
4663fa3
Compare
karrtikr
changed the title
karrtikr
changed the title
karthiknadig
approved these changes
Apr 29, 2021
|
@karrtikr can you rebase with main. The Sonar issue should be fixed in main. |
kimadeline
approved these changes
Apr 29, 2021
| @@ -193,10 +198,6 @@ async function activateLegacy(ext: ExtensionState): Promise<ActivationResult> { | |||
|
|
|||
| serviceManager.get<ICodeExecutionManager>(ICodeExecutionManager).registerCommands(); | |||
|
|
|||
| interpreterManager | |||
There was a problem hiding this comment.
Were there any issues caused by the absence of await here?
There was a problem hiding this comment.
The extension would finish loading (Python extension loading... text would disappear) but the user won't see the selected interpreter in the status bar, which might be confusing.
This improves things a bit, but it might increase extension activation time we record in telemetry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For https://github.com/microsoft/vscode-python-internalbacklog/issues/149 closes https://github.com/microsoft/vscode-python-internalbacklog/issues/156
This means we need to make the process of getting active interpreter faster.