Skip to content

Fix for filenames or folders starting with py. #17275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2021
Merged

Fix for filenames or folders starting with py. #17275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
903611c
Fix for filenames starting with py.
karthiknadig Sep 3, 2021
e338374
Add news item.
karthiknadig Sep 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/17270.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix for test result not found for files starting with py.
2 changes: 1 addition & 1 deletion src/client/testing/testController/common/resultsHelper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export async function updateResultFromJunitXml(
}

const result = junitSuite.testcase.find((t) => {
const idResult = getRunIdFromRawData(`${t.$.classname}.${t.$.name}`);
const idResult = getRunIdFromRawData(`${t.$.classname}::${t.$.name}`);
const idNode = rawTestCaseNode.runId;
return idResult === idNode || idNode.endsWith(idResult);
});
Expand Down
5 changes: 4 additions & 1 deletion src/client/testing/testController/common/testItemUtilities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,12 @@ function getRangeFromRawSource(raw: { source: string }): Range | undefined {
}

export function getRunIdFromRawData(id: string): string {
// TODO: This is a temporary solution to normalize test ids.
// The current method is error prone and easy to break. When we
// re-write the test adapters we should make sure we consider this.
// This is the id that will be used to compare with the results.
const runId = id
.replace(/\.py/g, '')
.replace(/\.py[^\w\-]/g, '') // we want to get rid of the `.py` in file names
.replace(/[\\\:\/]/g, '.')
.replace(/\:\:/g, '.')
.replace(/\.\./g, '.');
Expand Down