Skip to content

Getting started walkthrough for data scientists #18321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 24, 2022
Merged

Getting started walkthrough for data scientists #18321

merged 16 commits into from
Jan 24, 2022

Conversation

minsa110
Copy link

For microsoft/vscode-jupyter-internal#243

@kimadeline
Copy link

Hi @minsa110! Let me know if/when you need a review on this PR.

@minsa110
Copy link
Author

@brettcannon this is for the getting started experiment: https://github.com/microsoft/devdiv-exp-reviews/issues/112 :)

@minsa110
Copy link
Author

@kimadeline GitHub didn't update your comment for me until after I posted my previous comment.. Anyways, I was hoping we can get it in by Friday so that this would be in stable for the next release? Thank you for asking! :)

@brettcannon
Copy link
Member

This actually needs to land by Monday afternoon to make the next release.

@luabud luabud added the no-changelog No news entry required label Jan 21, 2022
@luabud luabud requested review from brettcannon and luabud January 21, 2022 01:28
@kimadeline
Copy link

The package-lock changes may not go away if you use a version of Node that's not the one recommended in the wiki. Copy-paste the one from main and replace this one, no one saw anything 🚮

@luabud
Copy link
Member

luabud commented Jan 21, 2022

@kimadeline thank you!!!

@luabud luabud added the skip package*.json package.json and package-lock.json don't both need updating label Jan 21, 2022
@luabud
Copy link
Member

luabud commented Jan 21, 2022

Just noticed the walkthrough with the link to the data science walkthrough did not have the new tiles that we recently added to the Python walkthrough, so I just added that now.

@luabud
Copy link
Member

luabud commented Jan 21, 2022

After talking to @brettcannon I ended up removing the tiles with "when":"false" as they won't show up anyway.

@minsa110
Copy link
Author

After talking to @brettcannon I ended up removing the tiles with "when":"false" as they won't show up anyway.

@luabud, could you revert this one? It would show up if a user clicks on "Learn more about getting started with data science" in the pythonWelcomeWithDS tile.

@luabud
Copy link
Member

luabud commented Jan 24, 2022

@minsa110 the tiles that I removed were the install Python and open folder ones, and they do not show up if they have the "when":"false" clause -- only the whole walkthroughs can be open when "when":"false" exists 🤔

@minsa110
Copy link
Author

@luabud yea, I didn't expand below. Looks good, thank you! Will merge now :)

@minsa110 minsa110 merged commit e3f9cc3 into main Jan 24, 2022
@minsa110 minsa110 deleted the exptest branch January 24, 2022 17:00
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…hon#18321)

* DS walkthrough consolidation experiment

* fix python DS walkthrough exp

* walkthrough experiment edits

* DS walkthrough consolidation experiment

Fix merge conflicts

* fix python DS walkthrough exp

* walkthrough experiment edits

* Fix package-lock.json

* Address PR comments

* Run npm install after fixing typescript version entry

* Fix typescript entry on package.json

* Regenerate package-lock.json with the hopes it will go away from the PR

* restore package-lock.json

* Add new line:

* Update pythonwithDS walkthrough with new Python walkthrough tiles

* Remove tiles with 'when':false

Co-authored-by: luabud <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog No news entry required skip package*.json package.json and package-lock.json don't both need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants